add support for arrayContains in where #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice. That's exactly what the documentation for the Android library states (link). I'll submit your PR now. When you get a chance, could you paste the same unit tests into https://github.com/atn832/cloud_firestore_mocks/blob/master/test_driver/cloud_firestore_behaviors.dart? This ensures that cloud_firestore_mocks behaves the same as the real Firestore and Firestore emulator. I've filed #71 to keep track of it. Thanks again for your pull request, @qwales1! |
|
Btw, I just published your PR. It is live at https://pub.dev/packages/cloud_firestore_mocks#043. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
arrayContains. This assumes that the correct behavior for using arrayContains on a field that is not of an array type is to not match any documents. This appears to be how it works in the JS SDK at least but I could not find a reference that explicitly states that.