Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the bundled Node version to v12.4.0 #5

Merged
merged 1 commit into from Aug 12, 2020
Merged

Update the bundled Node version to v12.4.0 #5

merged 1 commit into from Aug 12, 2020

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Aug 11, 2020

Description of the Change

Update bundled Node to v12.4.0, which matches the version in Electron 6.

Alternate Designs

None. We intend to match the Node version in apm to that which the version of Electron we use in Atom is based on.

Our Atom is using Electron 6. So we should bundle Node v12.4.0 in apm.

Benefits

For packages that try to detect the version of Node they are building against during install, this closely approximates the version of Node used in Atom's version of Electron. So if there are any potential bugs in various packages due to non-matching versions of Node/Electron, this should take care of 99% of them, maybe even all of them.

Possible Drawbacks

None expected. This is just a minor version update of Node.

Verification Process

CI and manual testing, to be done soon.

Applicable Issues

For a discussion of the type of issue this is designed to address, see: atom#328

@DeeDeeG DeeDeeG added this to In progress in 2.7.x via automation Aug 11, 2020
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Aug 12, 2020

Thanks for merging the other PRs.

I've indicated this elsewhere, but as a reminder: I am hoping there is a release with Node v12.0.0, and then this is for the next release after that (one minor release per Node version bump I guess).

Not that we can't do that right away if you want. Just that I'd like there to be an earlier release with Node v12.0.0.

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Aug 12, 2020

We do not have to bump dependencies or do any of the other to-dos I put before making a release (apm v2.7.0?) with Node v12.4.0.

I was thinking of e.g. bumping tar to v4 to match/dedupe with the version used by npm. And some things like that. The big "get rid of fs-plus" PR at upstream appears to need more work regarding try/catch blocks, so I won't be looking to merge it here soon while it's active at upstream. But none of this is super critical, and I can get to those things for later releases if need be.

@aminya
Copy link
Member

aminya commented Aug 12, 2020

Please rebase

This is the version of Node.js included in Electron 6.
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Aug 12, 2020

@aminya rebased. Thanks.

@aminya aminya merged commit 5941d63 into master Aug 12, 2020
2.7.x automation moved this from In progress to Done Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.7.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants