Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Bootstrapped Repository #10

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Upload Bootstrapped Repository #10

wants to merge 9 commits into from

Conversation

aminya
Copy link
Member

@aminya aminya commented Jul 4, 2020 •
edited

Description of the change

This adds a step to the release CI that uploads the ready bootstrapped repository. This provides a ready development environment for people to start hacking Atom's Core without running and dealing with the bootstrap script (similar to a pre-built docker images).

Verification

The CI passes

@DeeDeeG

This comment has been minimized.

Sign in to view
@aminya
Copy link
Member Author

aminya commented Jul 5, 2020

This gets uploaded to Azure artifacts. How do we upload it to the release page of GitHub?

@DeeDeeG
Copy link
Member

DeeDeeG commented Jul 5, 2020 •
edited

With the GitHub API I think.

Making a correct HTTP POST to the API some way or other.

https://docs.github.com/en/rest/reference/repos#upload-a-release-asset

Edit:

@aminya
Copy link
Member Author

aminya commented Jul 5, 2020

It seems we already have the scripts needed for releasing. We just need to test and try it to see if we need to add some variables or tokens.

@aminya aminya mentioned this pull request Jul 6, 2020
Closed
@aminya
Copy link
Member Author

aminya commented Jul 6, 2020 •
edited

We can probably reuse the bootstrapped repository in other jobs. Now MacOS bootstraps atom 4 times in total! (each being ~10min). We can reduce this time by uploading and downloading it.

One reason for Windows tests failing is that all the tests run at once in one machine which stops responding properly. If we reuse the bootstrapped repo, we can speed up the CI.

There is probably a better way. We might just cache the repository for the next job. This is easy in GitHub actions and should be possible in Azure too.
Edit: yes there exists!
https://docs.microsoft.com/en-us/azure/devops/pipelines/release/caching?view=azure-devops
https://devblogs.microsoft.com/devops/caching-and-faster-artifacts-in-azure-pipelines/

@DeeDeeG

This comment has been minimized.

Sign in to view
@aminya

This comment has been minimized.

Sign in to view
@DeeDeeG DeeDeeG mentioned this pull request Jul 7, 2020
Merged
@aminya aminya force-pushed the master branch 3 times, most recently from 0247565 to adaefd5 Compare July 8, 2020 15:33
@DeeDeeG DeeDeeG mentioned this pull request Jul 9, 2020
Merged
@aminya aminya changed the title Upload Bootstraped Repository Upload Bootstrapped Repository Jul 9, 2020
@aminya aminya marked this pull request as draft July 9, 2020 07:59
@aminya aminya added the CI label Jul 9, 2020
@aminya aminya linked an issue Jul 9, 2020 that may be closed by this pull request
Setting up Azure pipelines #1
Closed
@aminya aminya added this to In progress in Build, bootstrap, CI Jul 10, 2020
@DeeDeeG

This comment has been minimized.

Sign in to view
@DeeDeeG DeeDeeG closed this Jul 10, 2020
Build, bootstrap, CI automation moved this from In progress to Done Jul 10, 2020
@aminya aminya reopened this Jul 10, 2020
Build, bootstrap, CI automation moved this from Done to In progress Jul 10, 2020
@aminya
Copy link
Member Author

aminya commented Jul 10, 2020

I want to merge this eventually (only on release builds). We can release bootstrapped repositories with our binaries.

@aminya aminya self-assigned this Jul 16, 2020
@aminya aminya force-pushed the master branch 3 times, most recently from 0f34404 to 52de343 Compare July 16, 2020 13:31
@aminya aminya force-pushed the master branch 3 times, most recently from 87c664d to 67dcaef Compare September 18, 2020 12:24
@aminya aminya force-pushed the master branch 3 times, most recently from d5b2b31 to 1808785 Compare October 2, 2020 00:10
@aminya aminya marked this pull request as ready for review December 30, 2020 21:49
@aminya aminya closed this Jul 22, 2021
@aminya aminya closed this Jul 22, 2021
Build, bootstrap, CI automation moved this from In progress to Done Jul 22, 2021
@aminya aminya reopened this Jul 22, 2021
Build, bootstrap, CI automation moved this from Done to In progress Jul 22, 2021
@iamunadike
Copy link

As you can see most checks did not pass

@aminya
ci: add zip-upload template
037f03d
@aminya
upload bootstrapped repository
59c15a1 
to provide a ready development environment (similar to a pre-built
docker image)

Only uploaded the release job
@aminya
temp: upload bootsrap
7f6654c
@aminya
use publish template
5a95e69
@aminya
Use normal 7z compression
42764ee 
Benchmarks:
total size: 1.74 GB

method/time/final_size
ultra 2:19 494MB
maximum 1:52 511MB
normal 1:12 528MB
fast 0:40 604MB
fastest 0:32 658MB
@aminya
IsBuild variable
efb6ab4 
This shows if we are running the build job or the test job
@aminya
Upload the bootstrapped repo only in build job
32d5ab4
@aminya
Use Agent.OS instead of AGENT_OS
5658e46
@aminya
Use BUILD_ARCH
9b4f97d
ghost
ghost reviewed Jul 17, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest finding anything wrong because tests are not passing.

@aminya aminya removed their assignment Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
CI medium-priority
Projects
Build, bootstrap, CI
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting up Azure pipelines
3 participants
@aminya @DeeDeeG @iamunadike