Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache templates #39

Merged
merged 2 commits into from Jul 11, 2020
Merged

Cache templates #39

merged 2 commits into from Jul 11, 2020

Conversation

aminya
Copy link
Member

@aminya aminya commented Jul 11, 2020

Description of the Change

This refactors cache steps into a template.

Verification Process

Ran CI with these changes.

Release Notes

N/A

@aminya aminya merged commit 320bd33 into master Jul 11, 2020
@DeeDeeG
Copy link
Member

DeeDeeG commented Jul 11, 2020

I think the template is OS-aware without the windows|macos|linux parameters, due to the "$(Agent.OS)" part.

I think we can actually factor the parameters out/delete them.

@aminya
Copy link
Member Author

aminya commented Jul 11, 2020 •
edited

Agent.OS gives different strings such as Window_NT depending on the agent that is being used. Here, we want the exact windows string.

@aminya aminya added the CI label Jul 11, 2020
@aminya aminya added this to In progress in Build, bootstrap, CI via automation Jul 11, 2020
@aminya aminya moved this from In progress to Done in Build, bootstrap, CI Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI
Projects
Build, bootstrap, CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aminya @DeeDeeG