Skip to content

Commit

Permalink
Prepare v2.12.10 release
Browse files Browse the repository at this point in the history
  • Loading branch information
@UziTech
UziTech committed Nov 24, 2020
1 parent c2b502a commit fa39310
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "autocomplete-paths",
"main": "./dist/autocomplete-paths.js",
"version": "2.12.9",
"version": "2.12.10",
"description": "Adds path autocompletion to autocomplete+",
"repository": "https://github.com/atom-community/autocomplete-paths",
"license": "MIT",
Expand Down

9 comments on commit fa39310

@aviatesk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UziTech I think you should build this package again and update dist to take the changes in.

@UziTech
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is in the prepare script it should update dist when it installs.

/cc @aminya

@aviatesk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaiu the build step doesn't occur in installation.

@aminya
Copy link
Member

@aminya aminya commented on fa39310 Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is in the prepare script it should update dist when it installs.

/cc @aminya

Sorry, I had not set GitHub Actions here yet, so I manually did the registration for the previous releases. Manual registration requires you to run npm run build-commit before releasing.

https://github.com/atom-ide-community/atom-ide-template/blob/d2173cab457d47fd05446908f52bfc3961716e0e/.github/workflows/CI.yml#L67-L68

@UziTech
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install should run the prepare scripts according to the docs

@UziTech
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does apm install not run the prepare script?

@aminya
Copy link
Member

@aminya aminya commented on fa39310 Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm install does not:
atom-community/atom-ide-template#25

https://docs.npmjs.com/cli/v6/using-npm/scripts#npm-install

Npm does not run prepare if the package is a dependency of another package. Only top-level npm install triggers prepare. But postinstall is triggered no matter if it is top-level or not.

@UziTech
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot. That is why I hate build steps.

@aminya
Copy link
Member

@aminya aminya commented on fa39310 Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aviatesk now that you are here, could you take a look at these issues. That package is still awaiting registration.

JunoLab/atom-indent-detective#24
JunoLab/atom-indent-detective#23

Please sign in to comment.