[Bug fix] Protected files in / cause error #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows when typing / or \ the fs.statSync fails due to the file c:/hiberfil.sys, or others similar, not being readable. This causes a fatal error. Putting in this try catch statement allows for this to go wrong and will just move on regardless Fix for issue atom-community#13
|
+1 |
|
@saschagehlich Can you please implement this. This plugin is useless on Windows without this fix. If you don't have time, please give someone permission to this repo so they can maintain it. Thanks. |
yongkangchen
added a commit
that referenced
this pull request
Dec 16, 2014
[Bug fix] Protected files in / cause error
This was referenced Dec 16, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows when typing / or \ the fs.statSync fails due to the file c:/hiberfil.sys, or others similar, not being readable.
This causes a fatal error.
Putting in this try catch statement allows for this to go wrong and will just move on regardless
Fix for issue #13