feat: add proxy setting

[UziTech]

Add a proxy setting for gist location.

defaults to HTTPS_PROXY, https_proxy, HTTP_PROXY, or http_proxy environment variable.

fixes #619

[baatochan]

I would be very happy to test that but I don't know how to build and install this package with this commit. I've only ever installed atom packages via atom settings.

[UziTech]

You will have to do the following:

• Uninstall current sync-settings package in Atom
• Clone the repo: git clone https://github.com/uzitech/sync-settings
• Move to the source directory: cd sync-settings
• Checkout the branch: git checkout origin/proxy
• Run apm link
• Restart Atom

[baatochan]

Before you responded I'd found another instruction here and was able to install this version of package.

I can confirm that now it works, but there is one edge case when it doesn't. If I have set env var for proxy and I switch to network without proxy there is no way I can switch sync settings to not use the proxy. Entering "", '', into setting field (and I believe anything "blank" there) shows error: You must specify a "protocol" for the proxy type (http, https, socks, socks4, socks4a, socks5, socks5h, pac+data, pac+file, pac+ftp, pac+http, pac+https)

Edit: and leaving this field blank changes it to default value which is value of env var.

[UziTech]

I added a checkbox in the settings to disable the proxy even when it is set. Does that work for you?

[baatochan]

It works nice 👍

[UziTech]

Thanks for helping with this. I'll add some regression tests and get this released soon.

[github-actions]

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

• GitHub release
• Atom package

Your semantic-release bot 📦🚀

[Novocastrian]

Hi there,

I've entered my employer's proxy details into the settings as below (proxy.my.employer:8080):

However, when I restart Atom, it complains about the proxy type.

How do I fix this?

[UziTech]

@Novocastrian it looks like you need to add the protocol to the URL (http or https)

[UziTech]

You can see the supported protocols here

[Novocastrian]

@Novocastrian it looks like you need to add the protocol to the URL (http or https)

Yep! You're correct. I assumed that if you didn't declare HTTPS it would use HTTP. adding "HTTP://" to the start of the proxy address and rebooting fixed the issue for me.