Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where are the icons? #266

Closed
VijitCoder opened this issue Oct 3, 2019 · 2 comments
Closed

Where are the icons? #266

VijitCoder opened this issue Oct 3, 2019 · 2 comments
Labels
duplicate

Comments

@VijitCoder
Copy link

VijitCoder commented Oct 3, 2019 •
edited
Loading

After updating to tool-bar 1.1.13 icons disappeared!

2019-10-03_16-36
@VijitCoder VijitCoder changed the title Where is the icons? Where are the icons? Oct 3, 2019
@suda suda added the duplicate label Oct 3, 2019
@suda
Copy link
Collaborator

suda commented Oct 3, 2019

Hi Valery, we noticed this issue after publishing the package. Ionicons changed the naming of the icons and now they are available when adding ios- or md- prefix to the icon name, depending on the style you want. I unpublished the 1.1.13 version and published it as 1.2.0 to indicate the breaking change. The main conversation was held in #264

If you're populating those images yourself, you can add the prefixes mentioned above. If they were added by a separate package, please file an issue (or PR even) in their repo fixing this.

I'm terribly sorry for the inconvenience.

@suda suda closed this as completed Oct 3, 2019
@VijitCoder
Copy link
Author

Oh, I'm sorry. I didn't try to search the open issue, but should be. Thanks for directing me :)

@ericcornelissen ericcornelissen mentioned this issue Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suda @VijitCoder