icons disappear after update to v.1.1.13

[ptsonkov-work]

After update to v.1.1.13 all my icons disappear. Buttons are there but icons are not visible

[ptsonkov-work]

I figure it out. There is issue to load "ion" icons, please to fix this

[suda]

Oh I'm sorry to hear that! @ericcornelissen can you look into this?

[UziTech]

#265 is one fix for this. It just adds md- to any ion icon that isn't prefixed with ios- or md-

[petKitsune]

also
[not a tool-bar bug]
if md- does not do the trick
ion has changed some iconnames

[UziTech]

true. The best solution might just be telling people to make sure they are using the new icon names.

[ericcornelissen]

Oh I'm sorry to hear that! ericcornelissen can you look into this?

Ah yes, my apologies, I was unaware of the notable differences between the old and new version (should have checked 😅 again, my apologies). @UziTech's solution is definitely a good starter, though, as @petKitsune points out, it might not work for all icons as some names have changed. The only solution to that, I can think of at least, is to indeed tell people they may have to change some of the names (I don't think it is feasible to provide backwards compatibility in this package).

Alternatively you may consider reverting the change in v1.1.14 and releasing the new icons with v2.0.0 or v1.2.0 to signal breaking changes.

There is issue to load "ion" icons

Not sure what this means, Atom should have no problem finding the font as there is a test for that.

[suda]

You're right, we can't have backward compatibility here. Ionicons now offer iOS and Material style icons and the users should be able to select which one they prefer.

I unpublished 1.1.13 and published those changes as 1.2.0 with a warning.

We'll just have to inform any affected users about this change (I don't think there's a way to do it in an automated fashion).

Thank you all for quickly jumping on this!

[AriMKatz]

I'm getting this on 1.20

[ericcornelissen]

@AriMKatz check #268 for more details on how to resolve this issue. If you still have questions you can ask it there 😉

[PernilleF]

Where in the code do I add md- for getting the icons back?

[UziTech]

The code might be part of another package.

[AriMKatz]

Thanks, @ericcornelissen, It was a late night and I misread the thread, sorry for the noise.

[ericcornelissen]

Thanks, @ericcornelissen, It was a late night and I misread the thread, sorry for the noise.

Not a problem 😉 I'm happy to help.

Where in the code do I add md- for getting the icons back?

@PernilleF, As @UziTech said it might be another package, are you using any other packages with tool-bar (for example one of the ones listed here)? It might be possible to edit the configuration file for the toolbar yourself, in that case open the command pallete (Ctrl+Shift+P by default) and type something along the lines of "toolbar config file" and see if there is an option to edit it. Otherwise you will need to open an issue in the respective toolbar plugins (if there isn't already).

[aminya]

Adding ios- or md- doesn't help. My toolbar doesn't load at all. What should I do?
This is my package:
https://github.com/aminya/juno-toolbar-plus

[ericcornelissen]

My toolbar doesn't load at all. What should I do?

If the toolbar doesn't load at all there is probably a different issue 🤔 Do you see any errors in the developer tools of Atom (Ctrl+Shift+i or View -> Developer -> Toggle Developer Tools)?

If it is just a few icons that is missing, then I advice you to look at the Ionicons documentation and see if the icon still exists under the same name.

Hope that helps @aminya 🙂

[aminya]

@ericcornelissen I fixed the problem in the last version. The name of the icons was the issue causing the toolbar not to appear.