Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

Make the UI theme compatible with light syntax themes #11

Closed
silvestreh opened this issue Jun 24, 2015 · 7 comments
Closed

Make the UI theme compatible with light syntax themes #11

silvestreh opened this issue Jun 24, 2015 · 7 comments
Assignees
Milestone

Comments

@silvestreh
Copy link
Member

The user interface should be readable and usable with light syntax themes. Especially those shipped with Atom:

  • Atom Light
  • Base16 Tomorrow Light
  • Solarized Light
  • One Light
@silvestreh silvestreh self-assigned this Jun 24, 2015
@silvestreh silvestreh added this to the 1.0 Release milestone Jun 24, 2015
@silvestreh
Copy link
Member Author

Seems to be mostly fine now, but needs more testing… anyone using a light theme please create a new issue if you find something off.

@douglasm42
Copy link

In light themes the subtitles of the readmes are white, and pretty hard to see.
atom-material-ui

It's not related to this, but when i move the tabs sometimes these white borders appear, but on light themes its hard to notice.
atom-material-ui-moving

Also, my monitor have low contrast and it's very hard to see these kind of toggles, the scrollbar and the selected text, and its harder on light themes. But I managed changed the color of some of them to the accent color. I think it would be very cool to have some option to use the accent color on more things.
atom-material-ui-find

And thank you for the great UI theme.

@cobrabr
Copy link

cobrabr commented Jul 29, 2015

I have a similar problem -- I'm using the Grandson Of Obsidian Syntax theme (which is a dark theme), but for some reason, Atom Material UI thinks it's a light theme, so it colors the rest of the UI just like @douglasmfreitas's screenshot shows.

What's the exact configuration in the Syntax theme that Atom Material UI uses to determine whether the theme is light or dark?

@silvestreh
Copy link
Member Author

@cobrabr Grandson of Obsidian is an outdated syntax theme. It uses some deprecated classes and that's probably the issue here. There's not much I can do about it.

@cobrabr
Copy link

cobrabr commented Jul 29, 2015

Yeah, I noticed it after I posted my comment. Thanks for looking into it, anyway. :)

@nyc
Copy link

nyc commented Jul 30, 2015

In addition to the highlights in README files, the command palette also highlights letters matching a search in white font, making them impossible to read.

white-font-screenshot

This is using the Atom Light syntax theme.

@nyc
Copy link

nyc commented Jul 30, 2015

It also makes the wrap guide invisible. For example, using the Atom Light UI theme and the Atom Light syntax theme, you can see the wrap guide:

screen shot 2015-07-30 at 12 38 45 am

But it's not there with the Atom Material UI theme:

screen shot 2015-07-30 at 12 38 22 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants