Add controls to toggle the position of the minimap

atom-minimap · Feb 11, 2015 · 6434c34 · 6434c34
1 parent e16c69c
commit 6434c34
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/lib/minimap-quick-settings-element.coffee b/lib/minimap-quick-settings-element.coffee
@@ -14,6 +14,9 @@ class MinimapQuickSettingsElement extends HTMLElement
       @ol class: 'list-group mark-active', outlet: 'list', =>
         @li class: 'separator', outlet: 'separator'
         @li class: '', outlet: 'codeHighlights', 'code-highlights'
+      @div class: 'btn-group', =>
+        @button class: 'btn btn-default', outlet: 'onLeftButton', 'On Left'
+        @button class: 'btn btn-default', outlet: 'onRightButton', 'On Right'
 
   selectedItem: null
 
@@ -47,6 +50,20 @@ class MinimapQuickSettingsElement extends HTMLElement
       'focusout': (e) =>
         @destroy()
 
+    @subscriptions.add @subscribeTo @onLeftButton,
+      'mousedown': (e) ->
+        e.preventDefault()
+        atom.config.set('minimap.displayMinimapOnLeft', true)
+
+    @subscriptions.add @subscribeTo @onRightButton,
+      'mousedown': (e) ->
+        e.preventDefault()
+        atom.config.set('minimap.displayMinimapOnLeft', false)
+
+    @subscriptions.add atom.config.observe 'minimap.displayMinimapOnLeft', (bool) =>
+      @onLeftButton.classList.toggle('selected', bool)
+      @onRightButton.classList.toggle('selected', not bool)
+
     @initList()
 
   onDidDestroy: (callback) ->

diff --git a/spec/minimap-element-spec.coffee b/spec/minimap-element-spec.coffee
@@ -682,6 +682,9 @@ describe 'MinimapElement', ->
 
           quickSettingsElement = workspaceElement.querySelector('minimap-quick-settings')
 
+        it 'sets the on right button active', ->
+          expect(quickSettingsElement.querySelector('.btn.selected:last-child')).toExist()
+
         describe 'clicking on the code highlight item', ->
           beforeEach ->
             item = quickSettingsElement.querySelector('li:last-child')
@@ -693,6 +696,19 @@ describe 'MinimapElement', ->
           it 'requests an update', ->
             expect(minimapElement.frameRequested).toBeTruthy()
 
+        describe 'clicking on the on left button', ->
+          beforeEach ->
+            item = quickSettingsElement.querySelector('.btn:first-child')
+            mousedown(item)
+
+          it 'toggles the displayMinimapOnLeft setting', ->
+            expect(atom.config.get('minimap.displayMinimapOnLeft')).toBeTruthy()
+
+          it 'changes the buttons activation state', ->
+            expect(quickSettingsElement.querySelector('.btn.selected:last-child')).not.toExist()
+            expect(quickSettingsElement.querySelector('.btn.selected:first-child')).toExist()
+
+
         describe 'clicking on the open settings button again', ->
           beforeEach ->
             mousedown(openQuickSettings)

diff --git a/styles/minimap.less b/styles/minimap.less
@@ -104,4 +104,12 @@ minimap-quick-settings {
       background: @background-color-highlight;
     }
   }
+
+  .btn-group {
+    width: 100%;
+
+    .btn {
+      width: 50%;
+    }
+  }
 }