Add a with-minimal attribute on text editors

Gives a way to hide the scrollbar only when a minimap is present, as requested in #479
atom-minimap · May 20, 2016 · d76d410 · d76d410
1 parent bddefaf
commit d76d410
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/minimap-element.js b/lib/minimap-element.js
@@ -336,6 +336,7 @@ export default class MinimapElement {
    * @access private
    */
   detachedCallback () {
+    this.getTextEditorElement().removeAttribute('with-minimap')
     this.attached = false
   }
 
@@ -369,6 +370,10 @@ export default class MinimapElement {
   attach (parent) {
     if (this.attached) { return }
     (parent || this.getTextEditorElementRoot()).appendChild(this)
+
+    if (!parent) {
+      this.getTextEditorElement().setAttribute('with-minimap', '')
+    }
   }
 
   /**

diff --git a/spec/minimap-element-spec.js b/spec/minimap-element-spec.js
@@ -125,6 +125,10 @@ describe('MinimapElement', () => {
       window.requestAnimationFrame = requestAnimationFrameSafe
     })
 
+    it('adds a with-minimap attribute on the text editor element', () => {
+      expect(editorElement.hasAttribute('with-minimap')).toBeTruthy()
+    })
+
     it('takes the height of the editor', () => {
       expect(minimapElement.offsetHeight).toEqual(editorElement.clientHeight)
 
@@ -144,6 +148,14 @@ describe('MinimapElement', () => {
       expect(minimapElement.frameRequested).toBeTruthy()
     })
 
+    describe('when detached', () => {
+      it('removes the attribute from the editor', () => {
+        minimapElement.detach()
+
+        expect(editorElement.hasAttribute('with-minimap')).toBeFalsy()
+      })
+    })
+
     //     ######   ######   ######
     //    ##    ## ##    ## ##    ##
     //    ##       ##       ##