🐎 Register to styles changes only after being attached

It limits the amount of events an element receives on startup.
atom-minimap · Apr 2, 2015 · f466703 · f466703
1 parent 383000b
commit f466703
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/lib/minimap-element.coffee b/lib/minimap-element.coffee
@@ -40,15 +40,6 @@ class MinimapElement extends HTMLElement
     @subscriptions = new CompositeDisposable
     @initializeContent()
 
-    # Uses of `atom.styles.onDidAddStyleElement` instead of
-    # `atom.themes.onDidChangeActiveThemes`.
-    # Why?
-    # Currently, The styleElement will be removed first,
-    # and then re-add. So the `change` event has not be triggered.
-    @subscriptions.add atom.styles.onDidAddStyleElement =>
-      @invalidateCache()
-      @requestForcedUpdate()
-
     @observeConfig
       'minimap.displayMinimapOnLeft': (displayMinimapOnLeft) =>
         swapPosition = @minimap? and displayMinimapOnLeft isnt @displayMinimapOnLeft
@@ -89,6 +80,15 @@ class MinimapElement extends HTMLElement
     @measureHeightAndWidth()
     @attached = true
 
+    # Uses of `atom.styles.onDidAddStyleElement` instead of
+    # `atom.themes.onDidChangeActiveThemes`.
+    # Why?
+    # Currently, The styleElement will be removed first,
+    # and then re-add. So the `change` event has not be triggered.
+    @subscriptions.add atom.styles.onDidAddStyleElement =>
+      @invalidateCache()
+      @requestForcedUpdate()
+
   # Internal: DOM callback invoked when a new {MinimapElement} is detached
   # from the DOM.
   detachedCallback: ->