Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working in 0.177.0 #256

Closed
thislooksfun opened this issue Feb 6, 2015 · 15 comments
Closed

Stopped working in 0.177.0 #256

thislooksfun opened this issue Feb 6, 2015 · 15 comments

Comments

@thislooksfun
Copy link

After updating to Atom 0.177.0 and Minimap 4.1.0, the minimap stopped working.
Settings:
screen shot 2015-02-05 at 7 32 27 pm
Screenshot:
screen shot 2015-02-05 at 7 32 39 pm
It's probably something I have done, but I see no reason why it wouldn't be working.

@fundon
Copy link
Member

fundon commented Feb 6, 2015

It's working on my machine.

Disable other plugins and try again.

@abe33
Copy link
Contributor

abe33 commented Feb 6, 2015

FWIW have you tried disabling the hardware acceleration?

@thislooksfun
Copy link
Author

I tried both disabling all other (community) plugins, and disabled hardware acceleration, and it still doesn't work. Any other ideas? I love this plugin...

@fundon
Copy link
Member

fundon commented Feb 7, 2015

@thislooksfun Thanks reporting.

Maybe it's same as #255.

You can try this branch #258

@fundon
Copy link
Member

fundon commented Feb 7, 2015

@thislooksfun Update to the latest version(v4.1.2).

@thislooksfun
Copy link
Author

Nope. Still doesn't work. I'm going to try re-installing it.
EDIT: Re-installing did nothing. Trying a complete re-install of atom.
EDIT 2: Deleting the ~/.atom folder seemed to do the trick. No idea what I did, but I'll try to figure it out.
EDIT 3: It appears that restoring config.cson caused the error again. Will now try to find the settings that's causing the problem.
EDIT 4: Found it! Setting "preferredLineLength" to "999999999" causes the error.
EDIT 5: In fact, any value >= 16384 causes the error.

@fundon
Copy link
Member

fundon commented Feb 8, 2015

Good catch! Thanks @thislooksfun

@thislooksfun
Copy link
Author

No problem! Just a fair amount of trial and error. Not like I had anything better to do. :P
That number seems weirdly arbetrary though. I can't think of any reason off the top of my head as to why it would make a difference there. If it was a power of two, maybe, but 16384? Weird.

@fundon
Copy link
Member

fundon commented Feb 8, 2015

I'm trying to fix that.

@fundon
Copy link
Member

fundon commented Feb 8, 2015

fundon added a commit that referenced this issue Feb 8, 2015
…ength

fix softWrapAtPreferredLineLength bug, #256
@fundon
Copy link
Member

fundon commented Feb 8, 2015

Fixed in v4.1.3.

@fundon
Copy link
Member

fundon commented Feb 8, 2015

If it's still same issue, re-open it.

@fundon fundon closed this as completed Feb 8, 2015
@thislooksfun
Copy link
Author

It appears to be working now. However, I have also found that having the line length that high is a bad idea on it's own. Scrolling gets really slow. Thanks for fixing it though! Keep up the great work!

@abe33
Copy link
Contributor

abe33 commented Feb 9, 2015

I should have seen it coming. We'll need to make sure the minimap canvas width never get this wide so that we avoid memory or performance hog.

@fundon If you have some time to write the tests corresponding to the fix so that we don't miss it the next time we touch the codebase.

@fundon
Copy link
Member

fundon commented Feb 9, 2015

@abe33 You are right 👍 , sorry. I will. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants