Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading screen DPI makes lines extra thick #450

Open
tomByrer opened this issue Feb 15, 2016 · 5 comments
Open

Downgrading screen DPI makes lines extra thick #450

tomByrer opened this issue Feb 15, 2016 · 5 comments
Labels

Comments

@tomByrer
Copy link

My MacBook Pro is Retina, older external monitor is not. Dragging Atom window from laptop to external monitor makes the lines thick. Fonts seem normal.
Workaround; refresh Atom, lines go back to expected thinness.

"Won't fix" is acceptable, since this is an easily workaround. More of an FYI in case someone else finds it.

@abe33
Copy link
Contributor

abe33 commented Feb 16, 2016

Hmm, interesting, do you mind telling me if you get different value for devicePixelRatio in the devtools console when you switch from one screen to the other?

@tomByrer
Copy link
Author

Yes, as expected (2 for laptop, 1 for external).
The thick lines will happen only for the showing tab; switching tabs fixes it. Also seems to happen only for the right most pane if in dual pane mode.

@abe33
Copy link
Contributor

abe33 commented Feb 16, 2016

Not sure what happens since we don't cache the device pixel ratio in the minimap, and we force a full refresh on resize (which should update the device pixel ratio used to render the minimap). I'll need to find the way to reproduce that as I don't have a retina device at the moment.

@abe33 abe33 added the bug label Feb 16, 2016
abe33 added a commit that referenced this issue Mar 6, 2016
@abe33
Copy link
Contributor

abe33 commented Mar 6, 2016

If you can try v4.20 and tell me if things got better? I added a media query listener that is suppose to catch when the device pixel ratio changes.

@tomByrer
Copy link
Author

Let me look when I get back into the office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants