Feature/quick settings custom element #269
Conversation
| @quickSettingsElement.destroy() | ||
| @quickSettingsSubscription.dispose() | ||
| else | ||
| MinimapQuickSettingsElement ?= require './minimap-quick-settings-element' |
There was a problem hiding this comment.
Line exceeds maximum allowed length
|
I had make a post on Atom'discuss. |
|
@abe33 see https://github.com/fundon/atom-minimap/blob/feature/quick_settings_custom_element/lib/minimap-element.coffee#L279 @applyStyles @controls,
width: Math.min(@canvas.width, @width) + 'px'The code should be replaced with: @applyStyles @controls,
width: Math.min(@canvas.width / devicePixelRatio, @width) + 'px'If the if canvasWidth isnt @canvas.width or @height isnt @canvas.height
@canvas.width = canvasWidth * devicePixelRatiobut the I think that this issue's point. |
|
The |
| minimum: 1 | ||
| maximum: 3 | ||
| default: window.devicePixelRatio | ||
| description: 'The device pixel ratio used to draw the canvas on high-DPI device.' |
There was a problem hiding this comment.
Line exceeds maximum allowed length
|
Yep, detects |
|
I added |
fundon
force-pushed
the
feature/quick_settings_custom_element
branch
from
3b2a4b0
to
7909b5c
Compare
|
|
||
| canvasTop = @minimap.getFirstVisibleScreenRow() * @minimap.getLineHeight() - @minimap.getScrollTop() | ||
|
|
||
| canvasTransform = @makeTranslate(0, canvasTop) | ||
| canvasTransform += " " + @makeScale(1/devicePixelRatio) if devicePixelRatio isnt 1 | ||
| canvasTransform += " " + @makeScale(1 / devicePixelRatio) if devicePixelRatio isnt 1 |
There was a problem hiding this comment.
Line exceeds maximum allowed length
|
Ok, I removed the setting. |
|
Yeah, it's released! 👍 |
No description provided.