Fixed case sensitivity issue #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added RetinaNet plugin
…nd pull requests (#42) * Added .github folder with templates for feature request and bug report * Added template for pull requests
* Added LICENSE * minor changes * license name added * copyright(c) added
* Added .github folder with templates for feature request and bug report * Added template for pull requests * Re-arranged .github template files
…changes fixed YOLOv8.py to use the DetectorBase class
* initialized docker file * git clone in dockerfile * git checkout to topguns/dockerfile added in dockerfile * replaced COPY with cp command * replaced ssh with https link of the repo * seperate RUN for each bash command * added / after mkdir commands * removed trailing && after RUN commands * correction in directory structure * cloning directly into topguns/dockerfile branch * removed copying docker scripts to container command * trying to install Python requirements using requirements.txt * changed matplotlib version to 3.7.2 in requirements.txt * conflicts in requirements.txt * changed numpy version in requirements.txt * enter_bash.sh working * testing base.sh and start.sh * added cv-bridge dependency * working on exposing ros2 topics inside the container to host machine * tested docker container, clip and ship * changed model dir path for docker container * cleaned Dockerfile * added requirement.txt, docker instructions * Initialized new Dockerfile with nvidia/cuda as base image * Changes in Readme * Minor changes to detector scripts * Docker container working * Added code to install nano in Dockerfile * Added arg in dockerfile to specify CUDA Version and added docker stop in run_devel.sh * Added feature to enter bash if container is running and remove the container after exit in run_devel. Changed tensorflow version to 2.14.0 * Added feature in run_devel to build docker image if it doesnt exist * Updated readme * Updated readme * correction in run_devel.sh * Attempting to build OpenCV from source * Added option to select base image in run_devel.sh * Env Variable for percep_ws * Updated readme * README.md changes * additions to README.md (#50) * fixed superimposed predictions on consecutive frames * Resolved the error : can't convert cuda:0 device type tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory * Added output class labels and confidences to output image, fixed issue with wrong sizes of bounding boxes * Removed code for building opencv from source from the dockerfiles * Code cleanup and fixed minor bugs * Code cleanup and fixed minor bugs * Changed model weight location --------- Co-authored-by: AaksharGarg <aakshargarg@gmail.com> Co-authored-by: deepansh <gl.deepansh@gmail.com> Co-authored-by: Deepansh Goel <56270096+sudo-deep@users.noreply.github.com> Co-authored-by: topguns837 <arjun.k@orangewood.co> Co-authored-by: Jasmeet Singh <jasmeet0915@gmail.com>
* Added build and test workflow * Corrected IMAGE_NAME varibles in run_devel.sh script * Corrected pull_requests trigger name * Removed -it option from docker run & added docker attach step * Removed PERCEP_WS_PATH environment variable and used github.workspace instead * Corrected container name in docker run * Corrected volume mount path * Removed not required arguments from docker run * Removed docker attach & used docker exec for colcon build * Added | character in run for multi-line command * Added container_name environment variable * Added jobs for lint and test * Updated linting job, added matrix for linter * Added package name field to lint job * Removed pep8 and mypy linter from action workflows * Added copyright notice, corrected according to lint * Updated worflow to pass arguments for linter, made some corrections * Removed arguments from workflow * Updated flake8 test to use setup.cfg as the config * Updated workflow to pass config argument to flake8 lint * Fixed variable name typo * Corrected variable used for config path * Updated lin job to setup ros humble * Added ros distribution field for lint steps * Updated flake8 config from default ament_flake8 config * Added project wide flake8 config file, some more lint corrections
* Re-wrote YOLOv5 Plugin using torch instead of OpenCV * Added copyright to YOLOv5 Detector * Removing flake8 linting issues * Removing flake8 linting issues --------- Co-authored-by: topguns837 <arjun.k@orangewood.co>
topguns837
force-pushed
the
topguns/case-sensitivity
branch
from
06b7189
to
10d83e6
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
The ObjectDetection node is responsible for loading the detectors but the detector_type ROS 2 param is case-sensitive.
Fixed this issue : #56
Fixes # (issue)
If you write
YOLOV5instead ofYOLOv5, the code will raise a ModuleNotFound errorType of change 📜
How Has This Been Tested? 👀
Tested using the given docker images
Test Configuration 🖥️