Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

[WIP] Add Service Dependency Hints / Metadata #387

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions spec/fixtures/autocomplete-superawesome.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"releases": {
"latest": "1.0.0"
},
"name": "autocomplete-superawesome",
"versions": {
"1.0.0": {
"dist": {
"tarball": "http://localhost:3000/tarball/test-module-1.0.0.tgz"
}
}
},
"services": {
"provides": ["supercomplete"],
"consumes": []
}
}
22 changes: 22 additions & 0 deletions spec/fixtures/service-delinter.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"name": "delinter",
"versions": {
"latest": "1.0.2",
"1.0.2": "1.0.2",
"1.0.1": "1.0.1",
"1.0.0": "1.0.0"
},
"metadata": {
"name": "delinter",
"providers": {
"1.0.0": ["delinter-superawesome"],
"1.0.1": ["delinter-superawesome", "delinter-ludicrouslyawesome"],
"1.0.2": ["delinter-ludicrouslyawesome"]
},
"consumers": {
"1.0.0": ["delinter"],
"1.0.1": ["delinter", "delinter-cubed"],
"1.0.2": ["delinter-cubed"]
}
}
}
22 changes: 22 additions & 0 deletions spec/fixtures/service-supercomplete.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"name": "supercomplete",
"versions": {
"latest": "1.2.3",
"1.2.2": "1.2.2",
"1.2.1": "1.2.1",
"1.2.0": "1.2.0",
"1.1.0": "1.1.0",
"1.0.0": "1.0.0"
},
"metadata": {
"name": "supercomplete",
"providers": {
"1.0.0": ["autocomplete-superawesome"],
"1.2.0": ["autocomplete-superawesome", "autocomplete-ludicrouslyawesome"]
},
"consumers": {
"1.0.0": ["supercomplete-plus"],
"1.2.0": ["supercomplete-plus", "supercomplete-squared"]
}
}
}
46 changes: 46 additions & 0 deletions spec/fixtures/services.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
[
{
"name": "supercomplete",
"versions": {
"latest": "1.2.3",
"1.2.2": "1.2.2",
"1.2.1": "1.2.1",
"1.2.0": "1.2.0",
"1.1.0": "1.1.0",
"1.0.0": "1.0.0"
},
"metadata": {
"name": "supercomplete",
"providers": {
"1.0.0": ["autocomplete-superawesome"],
"1.2.0": ["autocomplete-superawesome", "autocomplete-ludicrouslyawesome"]
},
"consumers": {
"1.0.0": ["supercomplete-plus"],
"1.2.0": ["supercomplete-plus", "supercomplete-squared"]
}
}
},
{
"name": "delinter",
"versions": {
"latest": "1.0.2",
"1.0.2": "1.0.2",
"1.0.1": "1.0.1",
"1.0.0": "1.0.0"
},
"metadata": {
"name": "delinter",
"providers": {
"1.0.0": ["delinter-superawesome"],
"1.0.1": ["delinter-superawesome", "delinter-ludicrouslyawesome"],
"1.0.2": ["delinter-ludicrouslyawesome"]
},
"consumers": {
"1.0.0": ["delinter"],
"1.0.1": ["delinter", "delinter-cubed"],
"1.0.2": ["delinter-cubed"]
}
}
}
]
17 changes: 17 additions & 0 deletions spec/fixtures/supercomplete-plus.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"releases": {
"latest": "1.0.0"
},
"name": "supercomplete-plus",
"versions": {
"1.0.0": {
"dist": {
"tarball": "http://localhost:3000/tarball/test-module-1.0.0.tgz"
}
}
},
"services": {
"provides": [],
"consumes": ["supercomplete"]
}
}
25 changes: 25 additions & 0 deletions spec/install-spec.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,18 @@ describe 'apm install', ->
app.get '/packages/atom-2048', (request, response) ->
response.sendfile path.join(__dirname, 'fixtures', 'atom-2048.json')

# Services
app.get '/services', (request, response) ->
response.sendfile path.join(__dirname, 'fixtures', 'services.json')
app.get '/services/supercomplete', (request, response) ->
response.sendfile path.join(__dirname, 'fixtures', 'service-supercomplete.json')
app.get '/services/delinter', (request, response) ->
response.sendfile path.join(__dirname, 'fixtures', 'service-delinter.json')
app.get '/packages/autocomplete-superawesome', (request, response) ->
response.sendfile path.join(__dirname, 'fixtures', 'autocomplete-superawesome.json')
app.get '/packages/supercomplete-plus', (request, response) ->
response.sendfile path.join(__dirname, 'fixtures', 'supercomplete-plus.json')

server = http.createServer(app)
server.listen(3000)

Expand Down Expand Up @@ -320,3 +332,16 @@ describe 'apm install', ->

runs ->
expect(callback.mostRecentCall.args[0]).toBeTruthy()

fdescribe 'when a package has a required service dependency', ->
it 'fails if no services are installed with a required service', ->
callback = jasmine.createSpy('callback')
apm.run(['install', "autocomplete-superawesome"], callback)

waitsFor 'waiting for install to complete', 600000, ->
callback.callCount is 1

runs ->
console.log 'hello'
console.log JSON.stringify(callback)
expect(callback.mostRecentCall.args[0]).toBeFalsy()