Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add ability to collapse directories #73

Merged
merged 2 commits into from
May 12, 2021
Merged

Add ability to collapse directories #73

merged 2 commits into from
May 12, 2021

Conversation

bign8
Copy link
Contributor

@bign8 bign8 commented Dec 31, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Add the ability to collapse directories.

collapsible-directories

Alternate Designs

No alternative designs were considered, but I'm open to suggestions!

Benefits

Users could collapse large and/or complicated directory structures.

Possible Drawbacks

None that I am aware of.

Applicable Issues

#55 - This isn't full tree-view integration, but it may be enough to feel like it.

@bign8 bign8 changed the title ✨ Add ability to collapse directories Add ability to collapse directories Dec 31, 2019
@bign8 bign8 marked this pull request as ready for review December 31, 2019 04:17
Comment on lines 1 to 2
/** @babel */

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bign8:collapsible-directories

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still nothingness...

@danielleoking7474
Copy link

@danielleoking7474
Copy link

`

`

@ThatXliner
Copy link

Please merge!

Comment on lines 1 to 2
/** @babel */

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still nothingness...

@bign8
Copy link
Contributor Author

bign8 commented Apr 3, 2021

I'm not quite sure what the Atom maintainers are looking for, so I tried to reach out on the Atom discussions page, maybe that can stir some interest.

Copy link
Contributor

@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for adding tests around this.

@antonyggvzvmnxxcx
Copy link

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Add the ability to collapse directories.

collapsible-directories

Alternate Designs

No alternative designs were considered, but I'm open to suggestions!

Benefits

Users could collapse large and/or complicated directory structures.

Possible Drawbacks

None that I am aware of.

Applicable Issues

#55 - This isn't full tree-view integration, but it may be enough to feel like it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants