Autocompletion results do not get filtered

[josa42]

Currently the autocompletion results do not get filtered or sorted. This behavior is confusing and breaks the tab completion, because the first item is used, not the best matching one.

That's what it currently looks like or me:

That's what I would expect:

I created a PR to implement filtering using atom/fuzzaldrin.

Which basically does this:

autocomplete-adapter.js

static completionItemsToSuggestions(completionItems: Array<CompletionItem> | CompletionList, request: atom$AutocompleteRequest): Array<atom$AutocompleteSuggestion> {
  return filter(
    (Array.isArray(completionItems) ? completionItems : completionItems.items || [])
      .map(s => AutocompleteAdapter.completionItemToSuggestion(s, request)),
    request.prefix,
    {key: 'filterText'}
  );
}

Please let me know what you think.

[damieng]

Really the language provider should be re-queried after each keypress to provide the best updated options.

I'm aware of a bug in the Omnisharp provider (language-csharp) that currently prevents this - are you seeing this problem in other language servers too?

[josa42]

Thanks for the answer.

I am implementing a client for emberwatch/ember-language-server. I think the language provider is re-queried after each keypress. But the results are not getting filtered.

While it sounds absolutely reasonable that the language server should filter the results, at least VSCode seems to filter the results somewhere. This is what I see with same language server in VSCode:

I may have to dig deeper into this 😃

[damieng]

Yeah I'm not opposed to having something like this baked into atom-languageclient although I think people would need to opt-in for when their language server doesn't do it for them. Otherwise we'll interfere with the process which should technically be yielding more accurate results.

Let me know how your investigation goes.

[josa42]

@damieng Filtering is now solved in the Language Server. Thank you for your input!