Clean up temporary files when running specs

spec/atom-environment-spec.coffee

@@ -1,10 +1,13 @@
 _ = require 'underscore-plus'
 path = require 'path'
-temp = require 'temp'
+temp = require('temp').track()
 AtomEnvironment = require '../src/atom-environment'
 StorageFolder = require '../src/storage-folder'
 
 describe "AtomEnvironment", ->
+  afterEach ->
+    temp.cleanupSync()
+
   describe 'window sizing methods', ->
     describe '::getPosition and ::setPosition', ->
       originalPosition = null
@@ -324,7 +327,7 @@ describe "AtomEnvironment", ->
 
   describe "::unloadEditorWindow()", ->
     it "saves the BlobStore so it can be loaded after reload", ->
-      configDirPath = temp.mkdirSync()
+      configDirPath = temp.mkdirSync('atom-spec-environment')
       fakeBlobStore = jasmine.createSpyObj("blob store", ["save"])
       atomEnvironment = new AtomEnvironment({applicationDelegate: atom.applicationDelegate, enablePersistence: true, configDirPath, blobStore: fakeBlobStore, window, document})
 
@@ -336,7 +339,7 @@ describe "AtomEnvironment", ->
 
   describe "::destroy()", ->
     it "does not throw exceptions when unsubscribing from ipc events (regression)", ->
-      configDirPath = temp.mkdirSync()
+      configDirPath = temp.mkdirSync('atom-spec-environment')
       fakeDocument = {
         addEventListener: ->
         removeEventListener: ->

spec/babel-spec.coffee

@@ -19,6 +19,7 @@ describe "Babel transpiler support", ->
 
   afterEach ->
     CompileCache.setCacheDirectory(originalCacheDir)
+    temp.cleanupSync()
 
   describe 'when a .js file starts with /** @babel */;', ->
     it "transpiles it using babel", ->

spec/command-installer-spec.coffee

@@ -1,6 +1,6 @@
 path = require 'path'
 fs = require 'fs-plus'
-temp = require 'temp'
+temp = require('temp').track()
 CommandInstaller = require '../src/command-installer'
 
 describe "CommandInstaller on #darwin", ->
@@ -20,6 +20,9 @@ describe "CommandInstaller on #darwin", ->
     spyOn(CommandInstaller::, 'getResourcesDirectory').andReturn(resourcesPath)
     spyOn(CommandInstaller::, 'getInstallDirectory').andReturn(installationPath)
 
+  afterEach ->
+    temp.cleanupSync()
+
   it "shows an error dialog when installing commands interactively fails", ->
     appDelegate = jasmine.createSpyObj("appDelegate", ["confirm"])
     installer = new CommandInstaller("2.0.2", appDelegate)

spec/compile-cache-spec.coffee

@@ -23,6 +23,7 @@ describe 'CompileCache', ->
   afterEach ->
     CSON.setCacheDir(CompileCache.getCacheDirectory())
     CompileCache.setAtomHomeDirectory(process.env.ATOM_HOME)
+    temp.cleanupSync()
 
   describe 'addPathToCache(filePath, atomHome)', ->
     describe 'when the given file is plain javascript', ->
@@ -81,6 +82,7 @@ describe 'CompileCache', ->
 
       error = new Error("Oops")
       expect(error.stack).toBe 'a-stack-trace'
+      console.log('stack ' + error.getRawStack())
       expect(Array.isArray(error.getRawStack())).toBe true
 
       waits(1)

spec/config-spec.coffee

@@ -1,5 +1,5 @@
 path = require 'path'
-temp = require 'temp'
+temp = require('temp').track()
 CSON = require 'season'
 fs = require 'fs-plus'
 
@@ -9,13 +9,14 @@ describe "Config", ->
   beforeEach ->
     spyOn(atom.config, "load")
     spyOn(atom.config, "save")
-    dotAtomPath = temp.path('dot-atom-dir')
+    dotAtomPath = temp.path('atom-spec-config')
     atom.config.configDirPath = dotAtomPath
     atom.config.enablePersistence = true
     atom.config.configFilePath = path.join(atom.config.configDirPath, "atom.config.cson")
 
   afterEach ->
     atom.config.enablePersistence = false
+    fs.removeSync(dotAtomPath)
 
   describe ".get(keyPath, {scope, sources, excludeSources})", ->
     it "allows a key path's value to be read", ->
@@ -486,8 +487,8 @@ describe "Config", ->
       observeHandler.reset() # clear the initial call
       atom.config.set('foo.bar.baz', "value 2")
       expect(observeHandler).toHaveBeenCalledWith("value 2")
-      observeHandler.reset()
 
+      observeHandler.reset()
       atom.config.set('foo.bar.baz', "value 1")
       expect(observeHandler).toHaveBeenCalledWith("value 1")
       advanceClock(100) # complete pending save that was requested in ::set

spec/default-directory-provider-spec.coffee

@@ -1,20 +1,26 @@
 DefaultDirectoryProvider = require '../src/default-directory-provider'
 path = require 'path'
 fs = require 'fs-plus'
-temp = require 'temp'
+temp = require('temp').track()
 
 describe "DefaultDirectoryProvider", ->
+  tmp = null
+
+  beforeEach ->
+    tmp = temp.mkdirSync('atom-spec-default-dir-provider')
+
+  afterEach ->
+    temp.cleanupSync()
+
   describe ".directoryForURISync(uri)", ->
     it "returns a Directory with a path that matches the uri", ->
       provider = new DefaultDirectoryProvider()
-      tmp = temp.mkdirSync()
 
       directory = provider.directoryForURISync(tmp)
       expect(directory.getPath()).toEqual tmp
 
     it "normalizes its input before creating a Directory for it", ->
       provider = new DefaultDirectoryProvider()
-      tmp = temp.mkdirSync()
       nonNormalizedPath = tmp + path.sep +  ".." + path.sep + path.basename(tmp)
       expect(tmp.includes("..")).toBe false
       expect(nonNormalizedPath.includes("..")).toBe true
@@ -24,7 +30,6 @@ describe "DefaultDirectoryProvider", ->
 
     it "creates a Directory for its parent dir when passed a file", ->
       provider = new DefaultDirectoryProvider()
-      tmp = temp.mkdirSync()
       file = path.join(tmp, "example.txt")
       fs.writeFileSync(file, "data")
 
@@ -40,7 +45,6 @@ describe "DefaultDirectoryProvider", ->
   describe ".directoryForURI(uri)", ->
     it "returns a Promise that resolves to a Directory with a path that matches the uri", ->
       provider = new DefaultDirectoryProvider()
-      tmp = temp.mkdirSync()
 
       waitsForPromise ->
         provider.directoryForURI(tmp).then (directory) ->

spec/file-system-blob-store-spec.coffee

@@ -1,4 +1,4 @@
-temp = require 'temp'
+temp = require('temp').track()
 path = require 'path'
 fs = require 'fs-plus'
 FileSystemBlobStore = require '../src/file-system-blob-store'
@@ -7,9 +7,12 @@ describe "FileSystemBlobStore", ->
   [storageDirectory, blobStore] = []
 
   beforeEach ->
-    storageDirectory = temp.path()
+    storageDirectory = temp.path('atom-spec-filesystemblobstore')
     blobStore = FileSystemBlobStore.load(storageDirectory)
 
+  afterEach ->
+    fs.removeSync(storageDirectory)
+
   it "is empty when the file doesn't exist", ->
     expect(blobStore.get("foo", "invalidation-key-1")).toBeUndefined()
     expect(blobStore.get("bar", "invalidation-key-2")).toBeUndefined()

spec/git-repository-provider-spec.coffee

@@ -1,6 +1,6 @@
 path = require 'path'
 fs = require 'fs-plus'
-temp = require 'temp'
+temp = require('temp').track()
 {Directory} = require 'pathwatcher'
 GitRepository = require '../src/git-repository'
 GitRepositoryProvider = require '../src/git-repository-provider'
@@ -11,6 +11,9 @@ describe "GitRepositoryProvider", ->
   beforeEach ->
     provider = new GitRepositoryProvider(atom.project, atom.config, atom.confirm)
 
+  afterEach ->
+    temp.cleanupSync()
+
   describe ".repositoryForDirectory(directory)", ->
     describe "when specified a Directory with a Git repository", ->
       it "returns a Promise that resolves to a GitRepository", ->

spec/git-repository-spec.coffee

@@ -1,11 +1,11 @@
-temp = require 'temp'
+temp = require('temp').track()
 GitRepository = require '../src/git-repository'
 fs = require 'fs-plus'
 path = require 'path'
 Project = require '../src/project'
 
 copyRepository = ->
-  workingDirPath = temp.mkdirSync('atom-working-dir')
+  workingDirPath = temp.mkdirSync('atom-spec-git')
   fs.copySync(path.join(__dirname, 'fixtures', 'git', 'working-dir'), workingDirPath)
   fs.renameSync(path.join(workingDirPath, 'git.git'), path.join(workingDirPath, '.git'))
   workingDirPath
@@ -19,6 +19,8 @@ describe "GitRepository", ->
 
   afterEach ->
     repo.destroy() if repo?.repo?
+    try
+      temp.cleanupSync() # These tests sometimes lag at shutting down resources
 
   describe "@open(path)", ->
     it "returns null when no repository is found", ->

spec/grammars-spec.coffee

@@ -1,6 +1,6 @@
 path = require 'path'
 fs = require 'fs-plus'
-temp = require 'temp'
+temp = require('temp').track()
 GrammarRegistry = require '../src/grammar-registry'
 Grim = require 'grim'
 
@@ -24,6 +24,7 @@ describe "the `grammars` global", ->
   afterEach ->
     atom.packages.deactivatePackages()
     atom.packages.unloadPackages()
+    temp.cleanupSync()
 
   describe ".selectGrammar(filePath)", ->
     it "always returns a grammar", ->
@@ -96,6 +97,7 @@ describe "the `grammars` global", ->
         )
         grammar1 = atom.grammars.loadGrammarSync(grammarPath1)
         expect(atom.grammars.selectGrammar('more.test', '')).toBe grammar1
+        fs.removeSync(grammarPath1)
 
         grammarPath2 = temp.path(suffix: '.json')
         fs.writeFileSync grammarPath2, JSON.stringify(
@@ -105,6 +107,7 @@ describe "the `grammars` global", ->
         )
         grammar2 = atom.grammars.loadGrammarSync(grammarPath2)
         expect(atom.grammars.selectGrammar('more.test', '')).toBe grammar2
+        fs.removeSync(grammarPath2)
 
     it "favors non-bundled packages when breaking scoring ties", ->
       waitsForPromise ->

spec/integration/helpers/start-atom.coffee

@@ -16,7 +16,7 @@ ChromedriverPort = 9515
 ChromedriverURLBase = "/wd/hub"
 ChromedriverStatusURL = "http://localhost:#{ChromedriverPort}#{ChromedriverURLBase}/status"
 
-userDataDir = temp.mkdirSync('atom-user-data-dir')
+userDataDir = null
 
 chromeDriverUp = (done) ->
   checkStatus = ->
@@ -38,6 +38,7 @@ chromeDriverDown = (done) ->
   setTimeout(checkStatus, 100)
 
 buildAtomClient = (args, env) ->
+  userDataDir = temp.mkdirSync('atom-user-data-dir')
   client = webdriverio.remote(
     host: 'localhost'
     port: ChromedriverPort

spec/main-process/file-recovery-service.test.js

@@ -2,19 +2,23 @@
 
 import {dialog} from 'electron'
 import FileRecoveryService from '../../src/main-process/file-recovery-service'
-import temp from 'temp'
 import fs from 'fs-plus'
 import sinon from 'sinon'
 import {escapeRegExp} from 'underscore-plus'
+const temp = require('temp').track()
 
 describe("FileRecoveryService", () => {
   let recoveryService, recoveryDirectory
 
   beforeEach(() => {
-    recoveryDirectory = temp.mkdirSync()
+    recoveryDirectory = temp.mkdirSync('atom-spec-file-recovery')
     recoveryService = new FileRecoveryService(recoveryDirectory)
   })
 
+  afterEach(() => {
+    temp.cleanupSync()
+  })
+
   describe("when no crash happens during a save", () => {
     it("creates a recovery file and deletes it after saving", () => {
       const mockWindow = {}
@@ -28,6 +32,8 @@ describe("FileRecoveryService", () => {
       recoveryService.didSavePath(mockWindow, filePath)
       assert.equal(fs.listTreeSync(recoveryDirectory).length, 0)
       assert.equal(fs.readFileSync(filePath, 'utf8'), "changed")
+
+      fs.removeSync(filePath)
     })
 
     it("creates only one recovery file when many windows attempt to save the same file, deleting it when the last one finishes saving it", () => {
@@ -48,6 +54,8 @@ describe("FileRecoveryService", () => {
       recoveryService.didSavePath(anotherMockWindow, filePath)
       assert.equal(fs.listTreeSync(recoveryDirectory).length, 0)
       assert.equal(fs.readFileSync(filePath, 'utf8'), "changed")
+
+      fs.removeSync(filePath)
     })
   })
 
@@ -64,6 +72,8 @@ describe("FileRecoveryService", () => {
       recoveryService.didCrashWindow(mockWindow)
       assert.equal(fs.listTreeSync(recoveryDirectory).length, 0)
       assert.equal(fs.readFileSync(filePath, 'utf8'), "some content")
+
+      fs.removeSync(filePath)
     })
 
     it("restores the created recovery file when many windows attempt to save the same file and one of them crashes", () => {
@@ -94,6 +104,8 @@ describe("FileRecoveryService", () => {
       recoveryService.didCrashWindow(anotherMockWindow)
       assert.equal(fs.readFileSync(filePath, 'utf8'), "D")
       assert.equal(fs.listTreeSync(recoveryDirectory).length, 0)
+
+      fs.removeSync(filePath)
     })
 
     it("emits a warning when a file can't be recovered", sinon.test(function () {
@@ -113,6 +125,8 @@ describe("FileRecoveryService", () => {
       assert.equal(logs.length, 1)
       assert.match(logs[0], new RegExp(escapeRegExp(filePath)))
       assert.match(logs[0], new RegExp(escapeRegExp(recoveryFiles[0])))
+
+      fs.removeSync(filePath)
     }))
   })
 

spec/module-cache-spec.coffee

@@ -1,13 +1,16 @@
 path = require 'path'
 Module = require 'module'
 fs = require 'fs-plus'
-temp = require 'temp'
+temp = require('temp').track()
 ModuleCache = require '../src/module-cache'
 
 describe 'ModuleCache', ->
   beforeEach ->
     spyOn(Module, '_findPath').andCallThrough()
 
+  afterEach ->
+    temp.cleanupSync()
+
   it 'resolves Electron module paths without hitting the filesystem', ->
     builtins = ModuleCache.cache.builtins
     expect(Object.keys(builtins).length).toBeGreaterThan 0

spec/package-manager-spec.coffee

@@ -1,6 +1,6 @@
 path = require 'path'
 Package = require '../src/package'
-temp = require 'temp'
+temp = require('temp').track()
 fs = require 'fs-plus'
 {Disposable} = require 'atom'
 {buildKeydownEvent} = require '../src/keymap-extensions'
@@ -17,6 +17,9 @@ describe "PackageManager", ->
   beforeEach ->
     workspaceElement = atom.views.getView(atom.workspace)
 
+  afterEach ->
+    temp.cleanupSync()
+
   describe "::getApmPath()", ->
     it "returns the path to the apm command", ->
       apmPath = path.join(process.resourcesPath, "app", "apm", "bin", "apm")
@@ -643,7 +646,7 @@ describe "PackageManager", ->
         [element, events, userKeymapPath] = []
 
         beforeEach ->
-          userKeymapPath = path.join(temp.path(), "user-keymaps.cson")
+          userKeymapPath = path.join(temp.mkdirSync(), "user-keymaps.cson")
           spyOn(atom.keymaps, "getUserKeymapPath").andReturn(userKeymapPath)
 
           element = createTestElement('test-1')
@@ -660,6 +663,8 @@ describe "PackageManager", ->
           atom.keymaps.watchSubscriptions[userKeymapPath].dispose()
           delete atom.keymaps.watchSubscriptions[userKeymapPath]
 
+          temp.cleanupSync()
+
         it "doesn't override user-defined keymaps", ->
           fs.writeFileSync userKeymapPath, """
           ".test-1":