Merge pull request #9067 from atom/as-memory-leaks

Avoid leaking DOM objects
atom · Oct 7, 2015 · 993419f · 993419f
2 parents 5e78ead + 8da8302
commit 993419f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/scrollbar-component.coffee b/src/scrollbar-component.coffee
@@ -12,6 +12,9 @@ class ScrollbarComponent
 
     @domNode.addEventListener 'scroll', @onScrollCallback
 
+  destroy: ->
+    @onScroll = null
+
   getDomNode: ->
     @domNode
 

diff --git a/src/text-editor-component.coffee b/src/text-editor-component.coffee
@@ -119,6 +119,12 @@ class TextEditorComponent
     @gutterContainerComponent?.destroy()
     @domElementPool.clear()
 
+    @verticalScrollbarComponent.destroy()
+    @horizontalScrollbarComponent.destroy()
+
+    @onVerticalScroll = null
+    @onHorizontalScroll = null
+
   getDomNode: ->
     @domNode
 
@@ -563,7 +569,7 @@ class TextEditorComponent
     @sampleBackgroundColors()
     @remeasureCharacterWidths()
 
-  handleDragUntilMouseUp: (dragHandler) =>
+  handleDragUntilMouseUp: (dragHandler) ->
     dragging = false
     lastMousePosition = {}
     animationLoop = =>

diff --git a/src/text-editor-presenter.coffee b/src/text-editor-presenter.coffee
@@ -129,7 +129,7 @@ class TextEditorPresenter
       @shouldUpdateCustomGutterDecorationState = true
       @emitDidUpdateState()
 
-    @model.onDidUpdateMarkers =>
+    @disposables.add @model.onDidUpdateMarkers =>
       @shouldUpdateLinesState = true
       @shouldUpdateLineNumbersState = true
       @shouldUpdateDecorations = true