Biscotto doesn't like object key in editor.coffee

[mcolyer]

@gjtorikian can you take a look at https://github.com/atom/atom/blob/master/src/editor.coffee#L1723-L1753 and see what's causing biscotto to throw

Cannot parse file /Users/mcolyer/github/atom/src/editor.coffee: Invalid object key

(I'd make an issue on biscotto but it's public).

[gjtorikian]

@mcolyer Sure. Can you gist me the editor.coffee file on your machine, or is it already committed on master/a branch?

[mcolyer]

What's in master is the same as my local.

[gjtorikian]

@mcolyer Oof, this is a weird one.

Check out lines 1703 and 1708: https://github.com/atom/atom/blob/master/src/editor.coffee#L1703-L1708

They have one extra space of indentation. Deleting the space fixes the problem.

I agree with the error (whitespace is significant in CoffeeScript) but the error message should really be fixed to be less mystic. It also has something specific to do with the global status right below (### Internal ###).

Issue filed: gjtorikian/biscotto#16

[mcolyer]

@kevinsawicki how does this not fail with coffeelint?

[kevinsawicki]

@mcolyer coffeelint's indentation rule was disabled for the Q usage since it complained about the then() indentation that @probablycorey started using.

23af63b

[mcolyer]

😢 I guess I can live with that.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!