Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

1.32.0-beta0 replaced open files with empty untitled files after the update #18124

Closed
2 of 4 tasks
CadenP opened this issue Sep 27, 2018 · 5 comments
Closed
2 of 4 tasks
Assignees
Labels

Comments

@CadenP
Copy link

CadenP commented Sep 27, 2018

Prerequisites

Description

I just updated to 1.32.0-beta0 from 1.31.0-beta1, and reopened Atom for the first time to find that all of the open files were changed to empty untitled files. From all appearances it had no effect on the files themselves. I had a mixture of open files from within the project, from without the project, and never saved files (used for notetaking). All existing files had no unsaved changes.

Steps to Reproduce

  1. Have open files on Atom 1.31.0-beta1 (or below?)
  2. Update Atom to 1.32.0-beta0
  3. Reopen Atom and observe

Expected behavior: [What you expect to happen]

Previously opened files are reopened, as per the norm.

Actual behavior: [What actually happens]

Previously opened files are each replaced by an empty "untitled" file.

Reproduces how often: [What percentage of the time does it reproduce?]

I only tried once... So I guess that makes it 100% 😄

Versions

Windows 10 Pro
Version 1803
OS Build 17134.285

Prior to Update:
Atom: 1.31.0-beta1
The rest: ???

Following Update:

atom --version
Atom : 1.32.0-beta0
Electron: 2.0.9
Chrome : 61.0.3163.100
Node : 8.9.3

apm --version
apm 2.1.2
npm 6.2.0
node 8.9.3 x64
atom 1.32.0-beta0
python
git 2.18.0.windows.1
visual studio

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

A screenshot of the result:

image

I also tried disabling TreeSitter (because I previously disabled it for language-babel and the update re-enabled it) and reopened Atom, but that had no effect.

Packages installed:

atom-ide-debugger-node@0.7.3
atom-ide-ui@0.13.0
atom-material-syntax@1.0.8
atom-material-ui@2.1.3
busy-signal@1.4.3
file-icons@2.1.25
flow-ide@1.12.0
hyperclick@0.1.5
ide-css@0.3.0
ide-flowtype@0.23.1
ide-html@0.4.2
ide-json@0.2.1
ide-php@0.7.15
intentions@1.1.5
language-babel@2.85.0
language-gradle@0.0.5
language-postcss@1.3.1
linter@2.2.0
linter-ui-default@1.7.1
semanticolor@3.6.0
set-syntax@0.4.0
teletype@0.13.3
@Aerijo
Copy link
Contributor

Aerijo commented Sep 27, 2018

@CadenP There may have been an incompatible change in the way the state is serialised. If you go to the files in your system's file navigator, they should all be as expected.

To fix the issue with Atom, you can try opening with atom --clear-window-state. This may clear unsaved changes being tracked by Atom, but will not affect any saved files.

Alternatively, I've found opening a file direclty inside the folder you want to open will trigger a "Use existing saved state or discard" dialogue. Picking the discard option (again, this will clear unsaved changes) will open the folder as expected. For both methods, future openings should behave as expected.

If this is not the case, please let us know.

@p-boiko
Copy link

p-boiko commented Sep 27, 2018

I was affected too.
@Aerijo suggestion worked for me. First run of atom-beta --clear-window-state cleared the editor's window from opened files, then I opened a couple of files, closed editor and ran atom-beta without parameters. Now the files are opened

@CadenP
Copy link
Author

CadenP commented Sep 27, 2018

The solution works as advertised. To be clear, for other readers, it does not reopen the original state (which was converted to empty untitled files), but that is understandable.

Thanks @Aerijo for the solution, and @p-boiko for the confirmation.

And yes, to my knowledge no files were modified by this change. I had ruled that out pretty quickly, so I'm happy to say that there is no lasting effect with this problem - other than losing some notes in some never-saved documents, but I knew the risks of doing that 😄

Should this issue be closed, then?

@rsese
Copy link
Contributor

rsese commented Sep 28, 2018

Let's leave the issue open for now - just to mention, I can reproduce as described in the OP while upgrading from 1.31.0-beta1 to 1.32.0-beta0 on Windows 10.

@lock
Copy link

lock bot commented Mar 30, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants