Unable to create Atom RPM package on Fedora 33 #21937
Comments
|
@DeeDeeG Maybe this is something you could help with? Is the |
|
Hi @mfonville. Sure, I'll take a look at this.
Yes. (To get probably unnecessarily specific: It's not the latest v7 of Taking a look at this error:
That is a very strict lint. This error from the aggressive lint in https://github.com/nodejs/node-gyp/blob/v7.1.2/gyp/gyp_main.py#L1 Options:
I would also like to see if |
|
Relevant docs from the Fedora wiki about adopting this "ambiguous shebangs are an error" policy: https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error Points to:
I think that is the configuration we need to do. (In this file, I think: https://github.com/atom/atom/blob/master/resources/linux/redhat/atom.spec.in) This seems like the easy way:
DeeDeeG@e6770cd (testing this as I get time). |
Fedora's script tries to coerce all shebangs to point to exact, system-provided binaries. For example: `#!/usr/bin/env sh` becomes `#!/usr/bin/sh`. Starting with Fedora 30, the script errors out when it encounters ambiguous, versionless `python` in shebangs. (`python2` and `python3` are allowed.) For example, this shebang causes an error: `#!/usr/bin/env python`. --- Disable this script for two reasons: 1) Fedora users should be able to build Atom without errors. 2) Consistent shebangs across builds of Atom on Ubuntu and Fedora. See: atom#21937 for more details. Fixes: atom#21937
Fedora's script tries to coerce all shebangs to point to exact, system-provided binaries. For example: `#!/usr/bin/env sh` becomes `#!/usr/bin/sh`. Starting with Fedora 30, the script errors out when it encounters ambiguous, versionless `python` in shebangs. (`python2` and `python3` are allowed.) For example, this shebang causes an error: `#!/usr/bin/env python`. --- Disable this script for two reasons: 1) Fedora users should be able to build Atom without errors. 2) Consistent shebangs across builds of Atom on Ubuntu and Fedora. See: #21937 for more details. Fixes: #21937
|
Building the RPM package goes without a hitch. Thank you for the time and effort! |
Prerequisites
Description
Unable to create RPM package on Fedora 33. Ambiguous-python-shebang errors occur when
brp-mangle-shebangsis processingnode-gyppython scripts.Steps to Reproduce
sudo dnf --assumeyes install make gcc gcc-c++ glibc-devel git-core libsecret-devel rpmdevtools libX11-devel libxkbfile-devel(See hacking-on-atom-core)script/bootstrapscript/build --create-rpm-packageExpected behavior:
An Atom RPM package should be created.
Actual behavior:
Reproduces how often:
Always. The errors on ambiguous python shebang are intended. See the links below:
Versions
git master (394b468)
The text was updated successfully, but these errors were encountered: