Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Subpixel antialiasing isn't consistently applied to all text in document #7772

Closed
adamsiembida opened this issue Jul 7, 2015 · 7 comments · Fixed by #8041
Closed

Subpixel antialiasing isn't consistently applied to all text in document #7772

adamsiembida opened this issue Jul 7, 2015 · 7 comments · Fixed by #8041

Comments

@adamsiembida
Copy link

  • Using Atom 1.0.0.
  • Using Windows 7.
  • The effect seems to happen on both of my monitors:
    • Primary monitor is 1920 x 1200 resolution.
    • Secondary monitor is 1280 x 1024 resolution.
  • Using One Light for both UI Theme and Syntax Theme, but it also happens if I use Atom Light on both.
  • Running atom --safe didn't make any difference (still has the same alternating blurry).

It seems that when editing some files, that subpixel antialiasing works for a couple lines, then doesn't work for a couple lines, then works for a few lines, then doesn't ...

capture

When you zoom in, you can see that lines 34-36 are working properly, but then line 37 doesn't have subpixel antialiasing applied.

zoom

The strange thing is that if I make a document of all "a" characters, for example, it all looks blurry, but at least it is consistent.

all_blurry

If I fill the document with all "0" characters, it looks like the top few lines are blurry, but the rest renders correctly.

@50Wliu
Copy link
Contributor

50Wliu commented Jul 8, 2015

@as-cii this seems like your territory :).

@as-cii
Copy link
Contributor

as-cii commented Jul 8, 2015

Hey @w1res, thanks for reporting this issue.

Other Windows users have been experiencing a similar problem (#3869 (comment)) but found out it was related to the DPI settings. Would you be willing to check that setting out in your Windows configuration?

Thank you!

@adamsiembida
Copy link
Author

I'm getting a value of 1 for window.devicePixelValue (from within the Atom console).

I haven't read too much about using Atom (so this might not be the right way to change it), but I added window.devicePixelRatio = 1.5; to init.coffee and restarted Atom. It didn't seem to make any change in appearance. Is that the right place to change it?

@as-cii
Copy link
Contributor

as-cii commented Jul 20, 2015

Thanks @w1res, sorry for letting you wait so long! 🙏

I'm getting a value of 1 for window.devicePixelValue (from within the Atom console).

I assume you are talking about window.devicePixelRatio here. If yes, then DPI settings are definitely not the culprit here but it rather seems like something is screwing up subpixel anti-aliasing. I am starting to think this may actually be caused by highlight decorations.

Have you been able to reproduce this since you first reported? I have just noticed you had the spell-check package enabled in the second screenshot you posted. Could you try disabling it and see if it helps in a similar document (e.g. a document made of a characters only)?

@50Wliu
Copy link
Contributor

50Wliu commented Jul 20, 2015

I may be hitting this as well; will try to write up some repro steps later on.

@adamsiembida
Copy link
Author

@as-cii @50Wliu I disabled off spell-check and now everything looks uniformly sharp across all lines. It seems like you were correct in guessing that it might be related.

In fact, I can have the Settings open in one tab, and the file open in the other, and when I enable/disable the spell-check package (and go back and forth between the tabs), I can see the issue return and then go away.

@lock
Copy link

lock bot commented Jan 21, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants