-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Conversation
I'd really rather see the guide/tutorial more intertwined than they are currently which is why I put them together. I think organizing our documentation around tasks (get started, create a theme, create a package) makes it simpler to find what you're looking for if you're new. That said I'm also not the one putting the time in on it, so ultimately I leave it up to you. |
I agree with @gjtorikian. Having the example jammed in there makes it hard to find. We can link to the example in the beginning of the reference/info section of the package doc. |
They are hosted on github right now
Change the event to `changer:magic` and reload the editor: | ||
|
||
```json | ||
"activationEvents": ["changer:toggle"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changer:magic
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch !
Other than my one comment, I like this |
Depend on the GitHub cloud instead
@benogle Rather than refer to local files, I ended up linking out to GitHub's cloud asset host: https://github.com/atom/atom/pull/1052/files#diff-6b8aea9919633dfccd46cb74e4735766R330 |
Resolves #1024.
This brings the Changer package tutorial a bit up-to-date. A few things to note:
/cc @benogle @mcolyer