This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Ensure atom.cmd --wait correctly waits in Windows cmd & powershell #11053
+1
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, love seeing a simpler (and functionally better) solution here 👍 📈 |
3 tasks
|
🎉 |
|
|
|
🚀 |
|
Can we please make sure this gets into the next beta? Will fix CI pipeline stuff, and I may need to make an atom/ci PR on the back of it. |
damieng
added a commit
that referenced
this pull request
Mar 5, 2016
Ensure atom.cmd --wait correctly waits in Windows cmd & powershell
|
@joefitzgerald It'll definitely be in v1.7.x when it hits beta. Or did you mean to ask for this to be pulled in to the next v1.6-beta? |
|
@lee-dohm, I'm asking it to be pulled into 1.6.x beta; beta is currently broken in this regard so will impact CI for people doing CI against windows stable, and people using atom on the command line if we don't fix it in beta. |
|
I'm all for including this in the 1.6 beta. The caveat is while it works in Powershell and Command Line it's still broken in Cygwin. |
as-cii
pushed a commit
that referenced
this pull request
Mar 29, 2016
Ensure atom.cmd --wait correctly waits in Windows cmd & powershell
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing solution caused Command Prompt to exit and sleep command is not built in to Windows.
New solution works by spawning powershell child process that passes it's PID to atom and then waits indefinitely. When atom terminates that process the parent process continues.
Tested in Command Prompt and Powershell in Windows 7 32-bit and Windows 10 64-bit.