-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Conversation
Somehow lots of tree-view specs failed in this PR, reverted master to previous HEAD. |
@zcbenz any idea of why those failed here? |
No, I have no idea of it. When I opened this PR the CI were just green, but after a day when I did a rebase, the CI became red. |
It looks like it was related to a fixture directory getting into a bad state, which might have been caused by something else. Can you push this again and so we can see if we can isolate what's happening here? |
I did some experiments by rebasing to different commits, in some older commits we would get the red CI when using atom-shell v0.7.x, but in HEAD and newer commits the CI turned green. Still not sure what caused those failures, but anyway they were fixed somewhere. I opened a new PR to update atom-shell to v0.7.3, and it's green now: #1191. |
🆒 I think the red build was caused by those test fixtures getting corrupted and when I cleaned them out it fixed the issue you were seeing. |
Yeah, I'm going to fix those specs right now to use a temp folder instead of moving things inside the |
From atom-shell v0.7.2 we are using the new breakpad crash reporter on both Windows and OS X, it doesn't require any symbol files to be present on users' machine, and we can generate nice stack traces on the server.
The crash reports submission url is temporarily set to the default one (http://54.249.141.255:1127), which is my ec2 machine running the atom/mini-breakpad-server.
Currently the operating system libraries' symbols were not resolved on the server side, since we need to generate breakpad symbols for all system libraries on all versions of operation systems. On Windows it's possible to generate the symbols from Microsoft's debugging symbols server, and Mozilla has a script to do it. On OS X we can just manually generate the symbols on 10.9 and 10.8.