Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Update atom-shell to v0.7.2. #1180

Merged
merged 2 commits into from
Nov 29, 2013
Merged

Update atom-shell to v0.7.2. #1180

merged 2 commits into from
Nov 29, 2013

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Nov 28, 2013

From atom-shell v0.7.2 we are using the new breakpad crash reporter on both Windows and OS X, it doesn't require any symbol files to be present on users' machine, and we can generate nice stack traces on the server.

The crash reports submission url is temporarily set to the default one (http://54.249.141.255:1127), which is my ec2 machine running the atom/mini-breakpad-server.

Currently the operating system libraries' symbols were not resolved on the server side, since we need to generate breakpad symbols for all system libraries on all versions of operation systems. On Windows it's possible to generate the symbols from Microsoft's debugging symbols server, and Mozilla has a script to do it. On OS X we can just manually generate the symbols on 10.9 and 10.8.

@zcbenz zcbenz merged this pull request into master Nov 29, 2013
@zcbenz zcbenz deleted the atom-shell-v0.7.2 branch November 29, 2013 06:57
@zcbenz
Copy link
Contributor Author

zcbenz commented Nov 29, 2013

Somehow lots of tree-view specs failed in this PR, reverted master to previous HEAD.

@mcolyer
Copy link
Contributor

mcolyer commented Dec 2, 2013

@zcbenz any idea of why those failed here?

@zcbenz
Copy link
Contributor Author

zcbenz commented Dec 2, 2013

No, I have no idea of it. When I opened this PR the CI were just green, but after a day when I did a rebase, the CI became red.

@mcolyer
Copy link
Contributor

mcolyer commented Dec 2, 2013

It looks like it was related to a fixture directory getting into a bad state, which might have been caused by something else. Can you push this again and so we can see if we can isolate what's happening here?

@zcbenz
Copy link
Contributor Author

zcbenz commented Dec 3, 2013

I did some experiments by rebasing to different commits, in some older commits we would get the red CI when using atom-shell v0.7.x, but in HEAD and newer commits the CI turned green. Still not sure what caused those failures, but anyway they were fixed somewhere.

I opened a new PR to update atom-shell to v0.7.3, and it's green now: #1191.

@mcolyer
Copy link
Contributor

mcolyer commented Dec 3, 2013

🆒 I think the red build was caused by those test fixtures getting corrupted and when I cleaned them out it fixed the issue you were seeing.

@kevinsawicki
Copy link
Contributor

Yeah, I'm going to fix those specs right now to use a temp folder instead of moving things inside the node_modules folder.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants