Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Windows shell integration system settings #12123

Merged
merged 7 commits into from Jul 20, 2016
Merged

Conversation

damieng
Copy link
Contributor

@damieng damieng commented Jul 8, 2016

This is the Atom side of atom/settings-view#811 that provides the parts necessary for that one and facilitates;

  1. Only installing the file handler by default (no more context menus by defaut but you keep them if you already have them)
  2. Allows side-by-side of Atom.exe and AtomBeta.exe which can set, unset and upgrade independently

@damieng damieng changed the title Initial checkpoint not yet tested with settings-view changes Windows shell integration system settings Jul 8, 2016
constructor: (key, parts) ->
@key = key
@parts = parts
isRegistered: (callback) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use fat arrows for these functions?

nit It is typical to have a blank line between functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fat arrows are required so that the @ operator points to this object not to the window when the callback functions are executed.

I can add spacing.

@damieng damieng merged commit 177c48d into master Jul 20, 2016
@damieng damieng deleted the windows-system-settings branch July 20, 2016 00:23
@Ben3eeE
Copy link
Contributor

Ben3eeE commented Jul 29, 2016

Allows side-by-side of Atom.exe and AtomBeta.exe which can set, unset and upgrade independently

Do we know when this is set to release? As in which beta version would be the first I can install side by side with stable? I am very interested in some 1.10 features but wouldn't want to lose safety of a stable install on main workstation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants