Remove shadow DOM from atom-text-editor

apm/package.json

@@ -6,6 +6,6 @@
     "url": "https://github.com/atom/atom.git"
   },
   "dependencies": {
-    "atom-package-manager": "1.12.5"
+    "atom-package-manager": "1.13.0"
   }
 }

dot-atom/styles.less

@@ -26,7 +26,7 @@ atom-text-editor {
   // background-color: hsl(180, 24%, 12%);
 }
 
-// To style other content in the text editor's shadow DOM, use the ::shadow expression
-atom-text-editor::shadow .cursor {
+// style UI elements inside atom-text-editor
+atom-text-editor .cursor {
   // border-color: red;
 }

package.json

@@ -47,6 +47,8 @@
     "nslog": "^3",
     "oniguruma": "6.1.0",
     "pathwatcher": "~6.5",
+    "postcss": "5.2.4",
+    "postcss-selector-parser": "2.2.1",
     "property-accessors": "^1.1.3",
     "random-words": "0.0.1",
     "resolve": "^1.1.6",
@@ -67,18 +69,18 @@
     "yargs": "^3.23.0"
   },
   "packageDependencies": {
-    "atom-dark-syntax": "0.27.0",
-    "atom-dark-ui": "0.52.0",
-    "atom-light-syntax": "0.28.0",
-    "atom-light-ui": "0.45.0",
-    "base16-tomorrow-dark-theme": "1.3.0",
-    "base16-tomorrow-light-theme": "1.3.0",
-    "one-dark-ui": "1.6.2",
-    "one-light-ui": "1.6.2",
-    "one-dark-syntax": "1.5.0",
-    "one-light-syntax": "1.5.0",
-    "solarized-dark-syntax": "1.0.5",
-    "solarized-light-syntax": "1.0.5",
+    "atom-dark-syntax": "0.28.0",
+    "atom-dark-ui": "0.53.0",
+    "atom-light-syntax": "0.29.0",
+    "atom-light-ui": "0.46.0",
+    "base16-tomorrow-dark-theme": "1.4.0",
+    "base16-tomorrow-light-theme": "1.4.0",
+    "one-dark-ui": "1.7.0",
+    "one-light-ui": "1.7.0",
+    "one-dark-syntax": "1.6.0",
+    "one-light-syntax": "1.6.0",
+    "solarized-dark-syntax": "1.1.0",
+    "solarized-light-syntax": "1.1.0",
     "about": "1.7.0",
     "archive-view": "0.62.0",
     "autocomplete-atom-api": "0.10.0",
@@ -87,43 +89,43 @@
     "autocomplete-plus": "2.33.1",
     "autocomplete-snippets": "1.11.0",
     "autoflow": "0.27.0",
-    "autosave": "0.23.1",
+    "autosave": "0.23.2",
     "background-tips": "0.26.1",
-    "bookmarks": "0.42.0",
+    "bookmarks": "0.43.1",
     "bracket-matcher": "0.82.2",
-    "command-palette": "0.39.0",
-    "deprecation-cop": "0.54.1",
+    "command-palette": "0.39.1",
+    "deprecation-cop": "0.55.1",
     "dev-live-reload": "0.47.0",
     "encoding-selector": "0.22.0",
     "exception-reporting": "0.40.0",
-    "find-and-replace": "0.202.1",
+    "find-and-replace": "0.203.0",
     "fuzzy-finder": "1.4.0",
-    "git-diff": "1.1.0",
+    "git-diff": "1.2.0",
     "go-to-line": "0.31.0",
     "grammar-selector": "0.48.2",
     "image-view": "0.60.0",
     "incompatible-packages": "0.26.1",
     "keybinding-resolver": "0.35.0",
     "line-ending-selector": "0.5.0",
     "link": "0.31.2",
-    "markdown-preview": "0.158.8",
+    "markdown-preview": "0.159.0",
     "metrics": "1.0.0",
     "notifications": "0.65.1",
     "open-on-github": "1.2.1",
-    "package-generator": "1.0.1",
-    "settings-view": "0.243.1",
+    "package-generator": "1.0.2",
+    "settings-view": "0.244.0",
     "snippets": "1.0.3",
-    "spell-check": "0.68.4",
+    "spell-check": "0.68.5",
     "status-bar": "1.6.0",
-    "styleguide": "0.47.2",
+    "styleguide": "0.47.3",
     "symbols-view": "0.113.1",
     "tabs": "0.103.0",
     "timecop": "0.33.2",
     "tree-view": "0.210.0",
     "update-package-dependencies": "0.10.0",
     "welcome": "0.35.1",
     "whitespace": "0.35.0",
-    "wrap-guide": "0.38.2",
+    "wrap-guide": "0.39.0",
     "language-c": "0.54.0",
     "language-clojure": "0.22.1",
     "language-coffee-script": "0.48.0",

spec/atom-reporter.coffee

@@ -97,7 +97,7 @@ class AtomReporter
     if @failedCount is 1
       @message.textContent = "#{@failedCount} failure"
     else
-      @message.textConent = "#{@failedCount} failures"
+      @message.textContent = "#{@failedCount} failures"
 
   reportSuiteResults: (suite) ->
 
@@ -110,42 +110,6 @@ class AtomReporter
   reportSpecStarting: (spec) ->
     @specStarted(spec)
 
-  addDeprecations: (spec) ->
-    deprecations = grim.getDeprecations()
-    @deprecationCount += deprecations.length
-    @deprecations.style.display = '' if @deprecationCount > 0
-    if @deprecationCount is 1
-      @deprecationStatus.textContent = "1 deprecation"
-    else
-      @deprecationStatus.textContent = "#{@deprecationCount} deprecations"
-
-    for deprecation in deprecations
-      @deprecationList.appendChild(@buildDeprecationElement(spec, deprecation))
-
-    grim.clearDeprecations()
-
-  buildDeprecationElement: (spec, deprecation) ->
-    div = document.createElement('div')
-    div.className = 'padded'
-    div.innerHTML = """
-      <div class="result-message fail deprecation-message">
-        #{marked(deprecation.message)}
-      </div>
-    """
-
-    for stack in deprecation.getStacks()
-      fullStack = stack.map ({functionName, location}) ->
-        if functionName is '<unknown>'
-          "  at #{location}"
-        else
-          "  at #{functionName} (#{location})"
-      pre = document.createElement('pre')
-      pre.className = 'stack-trace padded'
-      pre.textContent = formatStackTrace(spec, deprecation.message, fullStack.join('\n'))
-      div.appendChild(pre)
-
-    div
-
   handleEvents: ->
     listen document, 'click', '.spec-toggle', (event) ->
       specFailures = event.currentTarget.parentElement.querySelector('.spec-failures')
@@ -273,7 +237,6 @@ class AtomReporter
       specView = new SpecResultView(spec)
       specView.attach()
       @failedCount++
-    @addDeprecations(spec)
 
 class SuiteResultView
   constructor: (@suite) ->

spec/lines-yardstick-spec.coffee

@@ -70,7 +70,7 @@ describe "LinesYardstick", ->
         font-size: 12px;
         font-family: monospace;
       }
-      .function {
+      .syntax--function {
         font-size: 16px
       }
       """
@@ -144,7 +144,7 @@ describe "LinesYardstick", ->
           font-size: 12px;
           font-family: monospace;
         }
-        .function {
+        .syntax--function {
           font-size: 16px
         }
         """

spec/spec-helper.coffee

@@ -105,10 +105,10 @@ beforeEach ->
   addCustomMatchers(this)
 
 afterEach ->
+  ensureNoDeprecatedFunctionCalls()
+  ensureNoDeprecatedStylesheets()
   atom.reset()
-
   document.getElementById('jasmine-content').innerHTML = '' unless window.debugContent
-
   warnIfLeakingPathSubscriptions()
   waits(0) # yield to ui thread to make screen update more frequently
 
@@ -118,8 +118,9 @@ warnIfLeakingPathSubscriptions = ->
     console.error("WARNING: Leaking subscriptions for paths: " + watchedPaths.join(", "))
   pathwatcher.closeAllWatchers()
 
-ensureNoDeprecatedFunctionsCalled = ->
-  deprecations = Grim.getDeprecations()
+ensureNoDeprecatedFunctionCalls = ->
+  deprecations = _.clone(Grim.getDeprecations())
+  Grim.clearDeprecations()
   if deprecations.length > 0
     originalPrepareStackTrace = Error.prepareStackTrace
     Error.prepareStackTrace = (error, stack) ->
@@ -136,9 +137,19 @@ ensureNoDeprecatedFunctionsCalled = ->
     error = new Error("Deprecated function(s) #{deprecations.map(({originName}) -> originName).join ', '}) were called.")
     error.stack
     Error.prepareStackTrace = originalPrepareStackTrace
-
     throw error
 
+ensureNoDeprecatedStylesheets = ->
+  deprecations = _.clone(atom.styles.getDeprecations())
+  atom.styles.clearDeprecations()
+  for sourcePath, deprecation of deprecations
+    title =
+      if sourcePath isnt 'undefined'
+        "Deprecated stylesheet at '#{sourcePath}':"
+      else
+        "Deprecated stylesheet:"
+    throw new Error("#{title}\n#{deprecation.message}")
+
 emitObject = jasmine.StringPrettyPrinter.prototype.emitObject
 jasmine.StringPrettyPrinter.prototype.emitObject = (obj) ->
   if obj.inspect
@@ -154,12 +165,15 @@ jasmine.attachToDOM = (element) ->
   jasmineContent = document.querySelector('#jasmine-content')
   jasmineContent.appendChild(element) unless jasmineContent.contains(element)
 
-deprecationsSnapshot = null
+grimDeprecationsSnapshot = null
+stylesDeprecationsSnapshot = null
 jasmine.snapshotDeprecations = ->
-  deprecationsSnapshot = _.clone(Grim.deprecations)
+  grimDeprecationsSnapshot = _.clone(Grim.deprecations)
+  stylesDeprecationsSnapshot = _.clone(atom.styles.deprecationsBySourcePath)
 
 jasmine.restoreDeprecationsSnapshot = ->
-  Grim.deprecations = deprecationsSnapshot
+  Grim.deprecations = grimDeprecationsSnapshot
+  atom.styles.deprecationsBySourcePath = stylesDeprecationsSnapshot
 
 jasmine.useRealClock = ->
   jasmine.unspy(window, 'setTimeout')