This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Use file suffix to load specific platform keybindings. #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 21, 2014 16:03
Example: On osx `keymap.cson` and `keymap-darwin.cson` would load. But `keymap-win32.cson` would not load.
|
I changed this from using a file suffix to uses the entire filename. This way it matches how menu's handle platform specific bindings. |
|
Fixes #1453 |
| otherPlatforms = platforms.filter (name) -> name != process.platform | ||
|
|
||
| for filePath in fs.listSync(directoryPath, ['.cson', '.json']) | ||
| platform = path.basename(filePath).match(/^(\w+)\.\w+$/)?[1] |
There was a problem hiding this comment.
Do you need this regex now that you aren't using the suffix?
There was a problem hiding this comment.
I thought about using path.basename(filePath, path.extname(filePath)) not in otherPlatforms but that seemed just as ugly. Is there a cleaner way?
There was a problem hiding this comment.
Ah, I get it now, I prefer the basename/extname dance because then I don't have to think about what actually is in \w in case someone reports an issue about their keymap not loading someday.
This would be clear to me:
continue if path.basename(filePath, path.extname(filePath)) in otherPlatforms
probablycorey
pushed a commit
that referenced
this pull request
Jan 22, 2014
Use file suffix to load specific platform keybindings.
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Example: On OS X, keymap files named
keymap.csonanddarwin.csonwould load, butwin32.csonwould not load.