This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Make CLI installation easier. #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 21, 2014 18:00
| destinationPath = path.join(directory, 'bin', 'source') | ||
| commandFilePath = temp.openSync("atom-command").path | ||
| commandName = path.basename(commandFilePath) | ||
| instalationPath = temp.mkdirSync("atom-bin") |
|
Does the command show two dialogs on success when ran? |
|
It doesn't show two dialogs on success anymore. |
| else | ||
| atom.confirm | ||
| message: "Commands installed." | ||
| detailedMessage: "The shell commands `atom` and `apm` are installed." |
There was a problem hiding this comment.
I'm really tempted to switch this over to promises
|
Fixes #1270 |
probablycorey
pushed a commit
that referenced
this pull request
Jan 23, 2014
Make CLI installation easier.
This was referenced Sep 16, 2021
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
This was referenced Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup Atom will try and install
apmandatomto /usr/local/bin. If it can't a warning is logged to the console.If the command
window:install-shell-commandsis triggered or theAtom > Install Shell Commandsmenu item is clicked a dialog will pop-up on success or failure.Fixes #1270