New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate line and column numbers from URI handlers #16215

Merged
merged 2 commits into from Nov 17, 2017

Conversation

Projects
None yet
1 participant
@BinaryMuse
Member

BinaryMuse commented Nov 16, 2017

The URI query string should specify line and column numbers as a user would, starting at 1, while the Atom API starts at 0.

/cc @RobinDaugherty

Resolves BetterErrors/better_errors#356 (comment)

BinaryMuse added some commits Nov 16, 2017

Translate line and column numbers from URI handlers
The URI query string should specify line and column numbers as a user
would, starting at 1, while the Atom API starts at 0.

@BinaryMuse BinaryMuse merged commit 674eb1b into master Nov 17, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BinaryMuse BinaryMuse deleted the mkt-fix-uri-handler-off-by-one-line-error branch Nov 17, 2017

BinaryMuse added a commit that referenced this pull request Nov 17, 2017

Merge pull request #16215 from atom/mkt-fix-uri-handler-off-by-one-li…
…ne-error

Translate line and column numbers from URI handlers

(cherry picked from commit 674eb1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment