This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Directly require clipboard from Electron #16526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
As far as I can tell the "safe-clipboard" workaround was for an Electron bug that was fixed somewhere around atom-shell 0.24.0. Searching for "clipboard linux" on the electron issues list doesn't yield any crash results and the docs don't have anything Linux-specific, so I think that we should be good now.
Alternate Designs
None.
Why Should This Be In Core?
This cleans up some old code present in core.
Benefits
Requiring the clipboard is more straightforward.
Possible Drawbacks
It is possible that the crash still exists and I'm searching for the wrong thing.
Verification Process
I currently don't have a Linux distribution set up, so I'm unable to verify that using the renderer clipboard does not crash Atom.
Applicable Issues
Refs electron/electron#1372