This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Use correct executable name for Atom Dev.app in atom.sh on macOS #17716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR #17680 broke how
atom.sh
resolves the.app
file for the version of Atom it intends to launch because we now namedev
channel buildsAtom Dev.app
. This PR fixes the script to use the name of the.app
file thatatom.sh
is contained within when/usr/local/bin/atom
is symbolically linked to it.This only appears as an issue when calling
atom
with a parameter like--version
which follows a different code path that invokes the executable file atAtom Dev.app/Contents/MacOS/Atom Dev
Verification Process
/usr/local/bin/atom
toatom.sh
inside/Applications/Atom.app
and callingatom --version
returns Atom Stable info/usr/local/bin/atom
toatom.sh
inside/Applications/Atom Dev.app
and callingatom --version
returns Atom Dev info/usr/local/bin/atom
toatom.sh
inside/Applications/Atom Beta.app
and callingatom --version
returns Atom Beta info/usr/local/bin/atom
toatom.sh
inside/Applications/Atom Nightly.app
and callingatom --version
returns Atom Nightly info