Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct executable name for Atom Dev.app in atom.sh on macOS #17716

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
None yet
2 participants
@daviwil
Copy link
Member

daviwil commented Jul 19, 2018

Description of the Change

PR #17680 broke how atom.sh resolves the .app file for the version of Atom it intends to launch because we now name dev channel builds Atom Dev.app. This PR fixes the script to use the name of the .app file that atom.sh is contained within when /usr/local/bin/atom is symbolically linked to it.

This only appears as an issue when calling atom with a parameter like --version which follows a different code path that invokes the executable file at Atom Dev.app/Contents/MacOS/Atom Dev

Verification Process

  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom.app and calling atom --version returns Atom Stable info
  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom Dev.app and calling atom --version returns Atom Dev info
  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom Beta.app and calling atom --version returns Atom Beta info
  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom Nightly.app and calling atom --version returns Atom Nightly info

@daviwil daviwil requested a review from maxbrunsfeld Jul 19, 2018

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Jul 19, 2018

Thanks @maxbrunsfeld!

@daviwil daviwil merged commit e549841 into master Jul 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-fix-atom-sh branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.