Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Use correct executable name for Atom Dev.app in atom.sh on macOS #17716

Merged
merged 1 commit into from Jul 19, 2018

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Jul 19, 2018

Description of the Change

PR #17680 broke how atom.sh resolves the .app file for the version of Atom it intends to launch because we now name dev channel builds Atom Dev.app. This PR fixes the script to use the name of the .app file that atom.sh is contained within when /usr/local/bin/atom is symbolically linked to it.

This only appears as an issue when calling atom with a parameter like --version which follows a different code path that invokes the executable file at Atom Dev.app/Contents/MacOS/Atom Dev

Verification Process

  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom.app and calling atom --version returns Atom Stable info
  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom Dev.app and calling atom --version returns Atom Dev info
  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom Beta.app and calling atom --version returns Atom Beta info
  • Symlinking /usr/local/bin/atom to atom.sh inside /Applications/Atom Nightly.app and calling atom --version returns Atom Nightly info

@daviwil
Copy link
Contributor Author

daviwil commented Jul 19, 2018

Thanks @maxbrunsfeld!

@daviwil daviwil merged commit e549841 into master Jul 19, 2018
@daviwil daviwil deleted the dw-fix-atom-sh branch July 19, 2018 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants