This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Fix errors causing tests to fail when run from the UI #17750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some errors and noise in the console that has been occurring for me when running the tests in the UI.
atom-environment-spec.js
that emitted an auto-update-related event in the main process. This caused exceptions to be thrown in all of your other Atom windows. I found that this code path is now covered by other tests, so I simply removed the offending test.application-delegate.js
entailed adding many individual ipc listeners, resulting in frequentEventEmitter leak detected
warnings. I've refactored this code to use a single event listener.