Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sign PRs on release branches #19131

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented Apr 10, 2019

We have a check to not sign builds from PRs on the master branch, but there's no equivalent check on PRs to release branches.

This causes build failures on these PRs since we don't expose the signing keys as env variables on PRs (for security reasons).

This PR should fix this

rafeca added some commits Apr 10, 2019

@rafeca rafeca merged commit a0f41e7 into master Apr 10, 2019

2 checks passed

Atom Pull Requests #20190410.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the fix-prs-on-release-branches branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.