Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Separate lint into own job #21326

Merged
merged 11 commits into from Oct 8, 2020
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions script/vsts/lint.yml
@@ -0,0 +1,12 @@
jobs:
- job: Lint
timeoutInMinutes: 10
pool:
vmImage: ubuntu-latest
steps:
- script: |
cd script
npm ci
Aerijo marked this conversation as resolved.
Show resolved Hide resolved
displayName: Install script dependencies
- script: script/lint
displayName: Run linter
4 changes: 4 additions & 0 deletions script/vsts/nightly-release.yml
Expand Up @@ -4,6 +4,9 @@ jobs:
parameters:
NightlyFlag: --nightly

# Import lint definition
- template: lint.yml

# Import OS-specific build definitions
- template: platforms/windows.yml
- template: platforms/macos.yml
Expand All @@ -16,6 +19,7 @@ jobs:

dependsOn:
- GetReleaseVersion
- Lint
- Windows_test
- Linux
- macOS_tests
Expand Down
3 changes: 0 additions & 3 deletions script/vsts/platforms/linux.yml
Expand Up @@ -16,9 +16,6 @@ jobs:

- template: templates/bootstrap.yml

- script: script/lint
displayName: Run linter

- template: templates/build.yml

- template: templates/test.yml
Expand Down
3 changes: 0 additions & 3 deletions script/vsts/platforms/macos.yml
Expand Up @@ -21,9 +21,6 @@ jobs:

- template: templates/bootstrap.yml

- script: script/lint
displayName: Run linter

- template: templates/build.yml

# core main tests
Expand Down
5 changes: 0 additions & 5 deletions script/vsts/platforms/windows.yml
Expand Up @@ -30,11 +30,6 @@ jobs:

- template: templates/bootstrap.yml

- script: node script\vsts\windows-run.js script\lint.cmd
env:
BUILD_ARCH: $(BUILD_ARCH)
displayName: Run linter

- template: templates/build.yml

- template: templates/test.yml
Expand Down
3 changes: 3 additions & 0 deletions script/vsts/pull-requests.yml
Expand Up @@ -4,6 +4,9 @@ jobs:
# Import "GetReleaseVersion" job definition
- template: platforms/templates/get-release-version.yml

# Import lint definition
- template: lint.yml

# Import OS-specific build definitions
- template: platforms/windows.yml
- template: platforms/macos.yml
Expand Down
4 changes: 4 additions & 0 deletions script/vsts/release-branch-build.yml
Expand Up @@ -8,6 +8,9 @@ jobs:
# Import "GetReleaseVersion" job definition
- template: platforms/templates/get-release-version.yml

# Import lint definition
- template: lint.yml

# Import OS-specific build definitions.
- template: platforms/windows.yml
- template: platforms/macos.yml
Expand All @@ -19,6 +22,7 @@ jobs:

dependsOn:
- GetReleaseVersion
- Lint
- Windows_tests
- Linux
- macOS_tests
Expand Down