fix: require .node files directly to detect incompatible native modules

[aminya]

Description of the change

fix: require .node files directly to detect incompatible native modules

• This fixes the incompatible native module detection for the packages that require their .node files lazily
• Speeds up the performance of detection by directly require .node files instead of requiring the package

Fixed Issues

This bug is one of the reasons that all the terminal packages break whenever an Electron upgrade happens or when you don't use apm rebuild

An example of the packages that get fixed by this fix:
All the terminal packages that use node-pty-prebuilt-multiarch. Among them:

• https://github.com/atom-community/terminal
• x-terminal
• terminus
• atom-ink
• ...

There are many other issues. I need time to list all of them

Verification

The CI passes.

A test you can do:

• Download x-terminal package as an example
• Run npm rebuild in its directory under .atom/packages/x-terminal
• Now run atom. You will see that it appears in the list of incompatible packages. Before this PR, the package just used to break without appearing in the rebuild list.

[aminya]

@sadick254 @darangi This addresses one of the biggest headaches when Atom ships a new Electron. Traditionally, people had to manually go and rebuild the .node files for the packages that load native modules dynamically. I strongly recommend including this fix in the same version that the Electron upgrade is shipped to prevent this issue from happening again.

[the-j0k3r]

The support burden of each electron upgrade breaking current installs would be greatly alleviated by this PR, so thx at @aminya for these efforts.

[darangi]

Thanks for the effort 🎉 @aminya

[aminya]

You're welcome!

[the-j0k3r]

Congrats on merge, if this is backported into 1.56beta we may have some joy out of this sooner rater than later.

[the-j0k3r]

So apparently atom 1.56.0 doesn't include this fix see https://github.com/bus-stop/terminus/issues/219 could it be backported to next 1.56 release?

[Clcatalan11]

White

[michakinchen1988]

T