Update required dependencies for Debian/Ubuntu

[mfonville]

After trying to build Atom on a very bare Ubuntu install, I figured out some missing dependencies for building: atom/flight-manual.atom.io#683

That also implied these libraries are the actual correct dependencies

[mfonville]

@DeeDeeG would you maybe mind checking these for the Red Hat version?

[DeeDeeG]

@mfonville I know it's likely too late to ask, but it would be great if you could provide any error messages that let you know that these packages were needed. Or the names/paths of the needed files, for instance shared object (.so) files. (As I recall we found out in the previous PR, the package names may not be the same in .rpm land, but the shared object files have a fair chance of having the same name.)

Or not quite as time-saving, but what minimal environment did you use to find out these packages were needed? (The debian or ubuntu Docker images, maybe?)

[mfonville]

@DeeDeeG I unfortunately don't have the exact .so anymore. You can take a look at the PR for the Atom manual I submitted, in addition to that there were only some libraries that I did find, but later seemed to be implied by e.g gtk3 like: libxcomposite1 libxcursor1 libxdamage1 libatk1.0-0 libatk-bridge2.0-0 libgdk-pixbuf2.0-0; and libxtst6 did imply already for libxi6

The testing I did by building Atom on a Ubuntu Server ISO (20.04 in Virtualbox)

[mfonville]

@DeeDeeG could you check if #22076 works for you on RPM-based distros? Then both PRs can be merged.

[DeeDeeG]

I haven't really had the time to set aside and take a look at this. I'm afraid I might not for a couple of weeks.

[mfonville]

Ok, there is no hurry :-)

[Imreallycool8]

Is my inbox some sort of message system?

…

On Tue, Mar 23, 2021 at 11:05 AM Maarten Fonville ***@***.***> wrote: Ok, there is no hurry :-) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#22015 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATC5MHKY72UTR452VFQLYV3TFDJ6VANCNFSM4Y2JIFBQ> .

[DeeDeeG]

@Imreallycool8 perhaps you are subscribed to updates in this repository?

Look for this button at the top of the page:

You can click that and select a narrower option, such as "Participating and @mentions" or "Ignore" or "Custom".

[Imreallycool8]

Hello, how do I make a new window for just a text box?

[mfonville]

@darangi You can already safely merge this PR, the other PR for the RPM-dependencies does not have any direct dependency with this one.

Thank you

[DeeDeeG]

I'm giving this the old "Docker test". Results later today, if all goes to plan.

[DeeDeeG]

I can recommend adding libgbm1 to the requirements. Once that is installed, all tested Debian/Ubuntu versions can do atom-dev --version --no-sandbox, even in these very minimal Docker containers. (Outside of Docker this is already more than good enough, I think.)

Results:

• Debian
  • 8-slim (End-of-Life): needs libgbm.so.1 --> libgbm1 package ❌
  • 9-slim (oldest supported): good, no changes needed ✔️
  • 10-slim (newest supported): needs libgbm.so.1 --> libgbm1 package ❌
• Ubuntu
  • 16.04 (recently End-of-Life): good, no changes needed ✔️
  • 18.04 (oldest supported): needs libgbm.so.1 --> libgbm1 package ❌
  • 20.04: good, no changes needed ✔️
  • 20.10: good, no changes needed ✔️
  • 21.04 (newest supported): good, no changes needed ✔️

Testing method and notes (click to expand):

Similar to #22076 (comment)...

Once the Docker container is up and running, first do apt-get update && apt-get install nano to get a working text editor. Use nano to write out and save this script, or else apt-get will swallow some of the later commands and they won't actually run:

export DEBIAN_FRONTEND=noninteractive # skip manual configuration prompt during install of the `tzdata` package
apt-get install -y wget unzip
wget 'https://dev.azure.com/DeeDeeG/b/_apis/build/builds/1128/artifacts?artifactName=atom-amd64.deb&api-version=6.0&%24format=zip' -O _atom.zip
unzip _atom.zip
apt-get install -y ./atom-amd64.deb/atom-amd64.deb
atom-dev --version --no-sandbox
/usr/share/atom-dev/atom --version --no-sandbox
apm-dev --version

Then run this script with bash ./[script_filename_here].

Note: Debian 8 is tested only for my curiosity's sake. The bundled apm in the latest Atom has a dependency git-utils that refuses to run with Debian 8's old libstdc++.so.6. The latest Atom probably doesn't really work on Debian 8.

The error message (click to expand):

Error: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /usr/share/atom-dev/resources/app/apm/node_modules/git-utils/build/Release/git.node)

Note: For the now End-of-Life Debian 8 release, apt-get refuses to install a bare .deb package. So you have to use dpkg -i ./atom-amd64.deb/atom-amd64.deb then apt-get install -f to get the downloaded Atom .deb file installed, instead of apt-get install ./atom-amd64.deb/atom-amd64.deb. Then the rest of the script is the same.

[mfonville]

Ok, I added libgbm1 too.

Also I changed libasound2 from recommends to requires, because it is after further checking a strict requirement. Atom cannot start without it.

[DeeDeeG]

Looks good to me. 👍

I re-tested Debian 10 and Ubuntu 18.04, which had a missing dependency before, and I also re-tested Ubuntu 20.04 for good measure. All pass the "Docker test" now (test described above). I'm not re-testing the others as they all should pass now, and it takes too long to test all eight.

[sadick254]

@DeeDeeG Thank you for the additional tests.

[CyberzNet]

After trying to build Atom on a very bare Ubuntu install, I figured out some missing dependencies for building: atom/flight-manual.atom.io#683

That also implied these libraries are the actual correct dependencies

#22015 (comment)