This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Make hard tabs align to columns. #2225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a-m-s this looks good! But can you add some specs? |
|
Just for reference, here is a bit of info on writing specs for atom https://atom.io/docs/latest/writing-specs |
|
@a-m-s ping - please add some specs, so your pull request can be merged. |
|
Please merge!!! |
|
merge! |
|
I'd love to merge this, but specs need to be added before we can review it. If someone is really passionate this, feel free to fork this PR and add the some specs! |
|
a-m-s please write this spec. in addition remove conflict. Please! |
Merged
|
Thanks for finishing this, @kevinsawicki! I've had no time to work on it, and the specs turn out to be harder to get to grips with than the code. :-( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1845, at least for hard tabs.
I'm not sure what the proper behaviour for soft tabs should be, but this ought to leave them as before.