This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
🐧 .desktop file without capital letter #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .desktop file of Atom was named Atom.desktop but it should be renamed to atom.desktop because a .desktop should not contain capital letters as any other .desktop files in /usr/share/applications. Note that without that, it can be not easy to link the window with the .desktop file and then a dock/panel could not link a launcher with its window.
| tmpDir = if process.env.TMPDIR? then process.env.TMPDIR else '/tmp' | ||
| if installDir.indexOf(tmpDir) isnt 0 | ||
| desktopFile = path.join('resources', 'linux', 'Atom.desktop.in') | ||
| desktopInstallFile = path.join(installDir, 'share', 'applications', 'Atom.desktop') | ||
| desktopFile = path.join('resources', 'linux', 'atom.desktop.in') |
There was a problem hiding this comment.
This input file is checked in here: https://github.com/atom/atom/blob/master/resources/linux/Atom.desktop.in
So it needs to be renamed as well in the repository.
There was a problem hiding this comment.
Hello,
I'm not sure to understand what's wrong: this file has also been renamed:
resources/linux/Atom.desktop.in → resources/linux/atom.desktop.in
Or should I miss something else? :-)
There was a problem hiding this comment.
I'm sorry, I missed that in the diff.
|
Thanks for this 🚢 |
kevinsawicki
added a commit
that referenced
this pull request
Oct 13, 2014
🐧 .desktop file without capital letter
No problem :-) |
This was referenced Jan 21, 2020
This was referenced Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for developing and maintaining Atom!
I'm using it on GNU/Linux Ubuntu and it seems the launcher (
.desktopfile) has a capital letter in its name. It should be renamed toatom.desktopbecause a.desktopfile should not contain capital letters as any other.desktopfiles that we can find in/usr/share/applications.Note that we also have another problem because currently, the window's class of all Atom windows is
Atom Shellbut the launcher is namedAtom. We should also add this line in your.desktopfile:Because without that, it's not possible for a dock/panel (like Cairo-Dock) to link a launcher (
Atom) with its window (Atom Shell).But it's certainly better to rename the window's class and this is why I just created this pull request in the
atom-shellproject! => electron/electron#698Best Regards,
Matt