This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Allow users to create more than one empty buffer #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If no one has any objections, I'd like to merge this today. |
| @@ -212,6 +212,11 @@ describe "RootView", -> | |||
| expect(editSession.getPath()).toBeUndefined() | |||
| expect(rootView.getActivePane().focus).toHaveBeenCalled() | |||
|
|
|||
| it "can create multiple empty edit sessions as an item on a new pane", -> | |||
| editSession = rootView.open() | |||
| editSession = rootView.open() | |||
There was a problem hiding this comment.
What do you thinking about adding an assert for expect(editSession1).not.toBe editSession2 or else just nuke the assignments since they are currently unused.
There was a problem hiding this comment.
I'll add the expect
|
@kevinsawicki you ready? |
|
👍🚍👍 |
benogle
added a commit
that referenced
this pull request
Sep 24, 2013
Allow users to create more than one empty buffer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple new buffers with cmd+n!
This does the minimum. All buffers have the title 'untitled'. We could number them?
See #679