Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Do not autocomplete after finishing a percentage #97

Merged
merged 1 commit into from May 25, 2017
Merged

Conversation

50Wliu
Copy link
Contributor

@50Wliu 50Wliu commented May 25, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Do not autocomplete property values here: width: 100%|.

Alternate Designs

Adjusting ac+'s default prefix to include the percentage sign.

Benefits

No useless completions after a percent.

Possible Drawbacks

None?

Applicable Issues

Fixes #96

@50Wliu 50Wliu merged commit 9da537f into master May 25, 2017
@50Wliu 50Wliu deleted the wl-no-percentages branch May 25, 2017 18:43
@sebszocinski
Copy link

I've just noticed this fix is only applying to the percentage key like my original issue 96 but I commented an update saying it's actually on any modifier key or even a comma... eg:

image

@50Wliu
Copy link
Contributor Author

50Wliu commented Jul 21, 2017

It is expected that completions happen after a comma because it's a list separator. As for the others...if you can provide an example of where those would show up in a CSS file that would mess up autocompletions, I'll take a look. As it is, I'm having trouble imagining seeing those in a CSS file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions firing on percentage key ie 100%
2 participants