Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

Support for the Russian letters #32

Closed
wants to merge 3 commits into from

Conversation

ForNeVeR
Copy link
Contributor

Added the tests and fixed the implementation to work with Russian letters.

I haven't find the best way to encode proper \w in node.js regex, so I've decided to simply hardcode the alphabet in the way all Russian coders used to. Maybe we'll have to find a solution better than regexp.

(Test code contains an excerpt from Dostoyevsky's Crime and Punishment if you're interested.)

This fix will close #28.

@lazdmx
Copy link

lazdmx commented Sep 15, 2015

@kevinsawicki @lee-dohm any chances to get it merged?

@lazdmx
Copy link

lazdmx commented Sep 15, 2015

Guys! Since problem of matching of non-English chars affects many langs I think that it is better to define separate var like charRE with regexp assigned.

charRE =
///
[
  \w                                       # English
  \u0410-\u042F\u0401\u0430-\u044F\u0451   # Russian
]
///

It clarifies a way to add support to other languages.

@lazdmx
Copy link

lazdmx commented Sep 15, 2015

@50Wliu @kevinsawicki , @lee-dohm and others, please do not shelve this PR since it would make life a much easier for many people.

@lazdmx
Copy link

lazdmx commented Sep 18, 2015

кажется мне что ребята подзабили 😄, а до тех пор всем заинтересованным остается только патчить непосредственно в атоме ~/.atom/packages/autoflow/lib/autoflow.coffee как сделал @ForNeVeR тут

@kevinsawicki
Copy link
Contributor

There was a merge conflict that I resolved, this is now on master, thanks so much for fixing this and apologies for the delayed response.

If anyone wants other character sets supported, please open subsequent pull requests that follow the pattern outlined here.

@lazdmx
Copy link

lazdmx commented Oct 12, 2015

nice! thank you @kevinsawicki

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with Russian
4 participants