Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async test helpers #1079

Merged
merged 1 commit into from Jun 12, 2019

Conversation

@rafeca
Copy link
Contributor

commented May 8, 2019

They are not needed anymore after atom/atom#18917 馃帀

spec/results-model-spec.js Outdated Show resolved Hide resolved
@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

They are not needed anymore after atom/atom#18917 馃帀

Oh damm it! I just realized that this commit hasn't reached stable yet!

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

I'll leave this one open until next week, when that change will get to stable

@rafeca rafeca force-pushed the remove-async-test-helpers branch from 3fed5da to 50026d3 Jun 10, 2019

@rafeca rafeca force-pushed the remove-async-test-helpers branch from 50026d3 to cf19f70 Jun 11, 2019

@rafeca rafeca merged commit 3ec6b30 into master Jun 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the remove-async-test-helpers branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.