Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix #591 - ReplaceNext shouldn't skip current selection. #607

Merged
merged 3 commits into from Dec 3, 2015
Merged

Fix #591 - ReplaceNext shouldn't skip current selection. #607

merged 3 commits into from Dec 3, 2015

Conversation

colllin
Copy link
Contributor

@colllin colllin commented Nov 28, 2015

Before:
before

After:
after

Fixes #591

benogle
benogle reviewed Nov 30, 2015
View reviewed changes
spec/fixtures/sample.js
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this change?

@benogle
Copy link
Contributor

benogle commented Nov 30, 2015

Other than the sample change, this LGTM.

@benogle
Copy link
Contributor

benogle commented Nov 30, 2015

Thanks for fixing this btw ❤️

@benogle benogle added the atom label Dec 1, 2015
@colllin
Copy link
Contributor Author

colllin commented Dec 2, 2015

Thanks for the review! I also noticed a function called selectFirstMarkerStartingFromCursor the other day, so I renamed the firstMarkerIndexFromCursor function to firstMarkerIndexStartingFromCursor to be consistent with that name.

benogle added a commit that referenced this pull request Dec 3, 2015
@benogle
Merge pull request #607 from colllin/replace-next-from-cursor
29b5b66 
Fix #591 - ReplaceNext shouldn't skip current selection.
@benogle benogle merged commit 29b5b66 into atom:master Dec 3, 2015
@colllin colllin deleted the replace-next-from-cursor branch December 7, 2015 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
atom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colllin @benogle