This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Reset search query when initialised #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting findPattern at startup prevents a user from rerunning their last query at startup. Because the object given to BufferSearch's onDidChange handler reports no change, its recreateMarkers method won't be called. This is handled in the specs by supplying the findOptions object a dummy string (reproducing a more realistic startup state). Without this patch, the first spec would fail.
|
Thanks @Alhadis! Sorry for letting this linger! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux of #762, which I closed after deciding the fix was too trivial to warrant another entry in the Atom team's creaking PR backlog.
Reopened after I lost ~10 minutes thinking a log hadn't been updated (and trying to debug why), only to realise I was being bitten by this bug the whole time. I realised there're probably many more users who're getting false negatives after rerunning a search at startup, which could cost them pointless time too...
/cc @maxbrunsfeld
Steps to reproduce
Expectation: Markers should appear in the buffer
Reality: The program beeps at you as if the field was left blank