Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add windows-build-tools to build instructions for Windows #420

Merged
merged 3 commits into from Jan 12, 2018
Merged

Add windows-build-tools to build instructions for Windows #420

merged 3 commits into from Jan 12, 2018

Conversation

ericcornelissen
Copy link
Contributor

As I suggested in atom/atom#15368, this adds windows-build-tools to the build requirements as an option for Visual Studio. That title is also changed to C++ build tools, as it no longer only lists products directly related to Visual Studio.

As I suggested in atom/atom#15368 over at the atom/atom repository, this adds windows-build-tools (https://www.npmjs.com/package/windows-build-tools) to the build requirements as an option for Visual Studio. That title is also changed to C++ build tools, as it no longer only lists products directly related to Visual Studio.
@lee-dohm
Copy link
Contributor

@damieng @daviwil What do you think about this addition? I don't know how stable/supported this npm package is, so I can't evaluate whether we would want to support this.

@daviwil
Copy link
Contributor

daviwil commented Jan 10, 2018

Thumbs up for windows-build-tools, it installs all the necessary C++ toolchain with zero headache. It also installs Python but for some reason our build script doesn't pick it up (unless you have to reboot before it shows up in the PATH). I'd say it's a good recommendation.

@ericcornelissen
Copy link
Contributor Author

It also installs Python but for some reason our build script doesn't pick it up (unless you have to reboot before it shows up in the PATH)

No it doesn't, see this issue (even though I thought it did 😅). So I guess the (Also installs Python 2.7.x) should be removed or changed for clarity...

@daviwil
Copy link
Contributor

daviwil commented Jan 10, 2018

It's possible we could add a check to the Windows build script to look for Python under the %HOME\.windows-build-tools path, then the prerequisite installation step will be much easier for Windows users.

@damieng
Copy link
Contributor

damieng commented Jan 10, 2018

I've not had any headache with the C++ Build Tools being installed directly and I'm reluctant to support a third way to get the C++ deps on the system especially as it involves a 3rd party package.

* Remove note about installing Python
* Move to bottom of list
* Add "Unsupported"
* Include note about convenience but need to know Node
@lee-dohm
Copy link
Contributor

Updated the PR with extra language since it isn't an official method of installation. Also placed it at the bottom of the list since we can't recommend it because again, it isn't official.

@lee-dohm
Copy link
Contributor

Thanks for the contribution 👍

@lee-dohm lee-dohm merged commit b51827b into atom:master Jan 12, 2018
@ericcornelissen ericcornelissen deleted the patch-1 branch January 13, 2018 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants